Fix wasm build in rust 1.85 #2326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it's incompatible. This means that in wasm we can't serialize/deserialize a field that contains a generics bound to type tagged trait (only `Artifact` trait is impacted). We only have one use case for this rigth now, storing artifacts in a generic database records field, which is not compiled to wasm so this is acceptable.
* mithril-common from `0.5.4` to `0.5.5`
sfauvel
approved these changes
Feb 21, 2025
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR fix build of the wasm library that's failing since release of
rust 1.85.$ npm run build:node > @mithril-dev/mithril-client-wasm@0.8.4 build:node > wasm-pack build --target nodejs --out-dir dist/node $WASM_PACK_ARGS [INFO]: 🎯 Checking for the Wasm target... [INFO]: 🌀 Compiling to Wasm... Compiling mithril-common v0.5.4 (/home/dev/mithril/mithril-common) Compiling mithril-client v0.11.3 (/home/dev/mithril/mithril-client) Compiling mithril-client-wasm v0.8.4 (/home/dev/mithril/mithril-client-wasm) Finished `release` profile [optimized] target(s) in 13.49s thread 'main' panicked at crates/wasm-interpreter/src/lib.rs:245:21: mithril_common::signable_builder::interface::_::__ctor::h4977fb9f7c35308c: Read a negative address value from the stack. Did we run out of memory? note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace Error: Running the wasm-bindgen CLI Caused by: Running the wasm-bindgen CLI Caused by: failed to execute `wasm-bindgen`: exited with exit status: 101This is due to an incompatibility between the type-tag crate and wasm.
Removing
typetagfrom the wasm build solve the issue at the price of not being able to use typetag bound generics fields with serde in wasm.This is acceptable because the only use case for type tag right now in our code base is in the
mithril-aggregator, that's not compiled to wasm, to serialize/deserialize in json theartifactfield of thesigned_entitytable.There's a remaining question: This incompatibility is not new and is not related to
rust 1.85so why wasm builds start to fails only now ?Pre-submit checklist
Issue(s)
Closes #2325