Implement signable and artifact builders for Cardano Stake Distribution #1847

dlachaume · 2024-07-19T16:56:12Z

Content

This PR implements the signable builder and artifact builder for the Cardano Stake Distribution, allowing the certification of the CardanoStakeDistribution. This signed entity type is now active in the end-to-end tests.

Pre-submit checklist

Branch
- Tests are provided (if possible)
- Crates versions are updated (if relevant)
- CHANGELOG file is updated (if relevant)
- Commit sequence broadly makes sense
- Key commits have useful messages
PR
- No clippy warnings in the CI
- Self-reviewed the diff
- Useful pull request description
- Reviewer requested
Documentation
- Update README file (if relevant)
- Update documentation website (if relevant)
- Add dev blog post (if relevant)

Issue(s)

Closes #1832

github-actions · 2024-07-19T17:03:07Z

Test Results

4 files ± 0 52 suites ±0 9m 14s ⏱️ +8s
1 191 tests +26 1 191 ✅ +26 0 💤 ±0 0 ❌ ±0
1 357 runs +26 1 357 ✅ +26 0 💤 ±0 0 ❌ ±0

Results for commit 4829708. ± Comparison against base commit 52a7beb.

♻️ This comment has been updated with latest results.

CHANGELOG.md

mithril-aggregator/src/artifact_builder/cardano_stake_distribution.rs

mithril-common/src/entities/cardano_stake_distribution.rs

mithril-common/src/entities/protocol_message.rs

mithril-common/src/signable_builder/cardano_stake_distribution.rs

mithril-common/src/signable_builder/signable_builder_service.rs

jpraynaud

LGTM 👍

…tributionArtifactBuilder` instead of `StakeStorer` Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>

…t is included in the computed merkle tree

…ignable and Artifact builders

…imePoint`

…ty type is signed Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>

jpraynaud

LGTM 👍

mithril-aggregator/src/http_server/routes/signatures_routes.rs

mithril-common/src/entities/signed_entity_type.rs

sfauvel

LGTM

internal/mithril-persistence/src/store/stake_store.rs

mithril-aggregator/src/database/repository/stake_pool_store.rs

mithril-common/src/entities/signed_entity_config.rs

- enhance `list_allowed_signed_entity_types` and `get_epoch_when_signed_entity_type_is_signed` implementations - modify comment in `/register-signatures` route, adding a 'TODO'

…bution to a higher level

dlachaume self-assigned this Jul 19, 2024

dlachaume requested review from jpraynaud and sfauvel July 19, 2024 17:07

dlachaume marked this pull request as ready for review July 19, 2024 17:07

dlachaume force-pushed the dlachaume/1832/implement-signable-artifact-builders-for-cardano-stake-distribution branch from 96b8bf2 to 3a434da Compare July 19, 2024 17:11

jpraynaud reviewed Jul 22, 2024

View reviewed changes

dlachaume force-pushed the dlachaume/1832/implement-signable-artifact-builders-for-cardano-stake-distribution branch from 3a434da to a03f1fb Compare July 22, 2024 16:43

dlachaume temporarily deployed to testing-preview July 22, 2024 16:50 — with GitHub Actions Inactive

dlachaume temporarily deployed to testing-sanchonet July 22, 2024 16:50 — with GitHub Actions Inactive

dlachaume force-pushed the dlachaume/1832/implement-signable-artifact-builders-for-cardano-stake-distribution branch from 3adca69 to 0a09070 Compare July 23, 2024 07:49

dlachaume had a problem deploying to testing-preview July 23, 2024 07:56 — with GitHub Actions Failure

dlachaume temporarily deployed to testing-sanchonet July 23, 2024 07:56 — with GitHub Actions Inactive

jpraynaud approved these changes Jul 23, 2024

View reviewed changes

dlachaume temporarily deployed to testing-preview July 23, 2024 08:09 — with GitHub Actions Inactive

dlachaume temporarily deployed to testing-sanchonet July 23, 2024 08:09 — with GitHub Actions Inactive

dlachaume force-pushed the dlachaume/1832/implement-signable-artifact-builders-for-cardano-stake-distribution branch from 0a09070 to 953657c Compare July 23, 2024 08:11

dlachaume temporarily deployed to testing-preview July 23, 2024 08:19 — with GitHub Actions Inactive

dlachaume temporarily deployed to testing-sanchonet July 23, 2024 08:19 — with GitHub Actions Inactive

dlachaume force-pushed the dlachaume/1832/implement-signable-artifact-builders-for-cardano-stake-distribution branch 2 times, most recently from 69f7395 to 6523568 Compare July 23, 2024 08:30

dlachaume temporarily deployed to testing-preview July 23, 2024 08:43 — with GitHub Actions Inactive

dlachaume temporarily deployed to testing-sanchonet July 23, 2024 08:43 — with GitHub Actions Inactive

dlachaume force-pushed the dlachaume/1832/implement-signable-artifact-builders-for-cardano-stake-distribution branch 2 times, most recently from 538db9f to 9e0e290 Compare July 23, 2024 09:17

dlachaume temporarily deployed to testing-preview July 23, 2024 09:24 — with GitHub Actions Inactive

dlachaume temporarily deployed to testing-sanchonet July 23, 2024 09:24 — with GitHub Actions Inactive

dlachaume force-pushed the dlachaume/1832/implement-signable-artifact-builders-for-cardano-stake-distribution branch from 9e0e290 to bc2b1a1 Compare July 23, 2024 09:30

dlachaume temporarily deployed to testing-preview July 23, 2024 09:36 — with GitHub Actions Inactive

dlachaume temporarily deployed to testing-sanchonet July 23, 2024 09:37 — with GitHub Actions Inactive

dlachaume temporarily deployed to testing-preview July 26, 2024 14:28 — with GitHub Actions Inactive

dlachaume temporarily deployed to testing-sanchonet July 26, 2024 14:28 — with GitHub Actions Inactive

dlachaume force-pushed the dlachaume/1832/implement-signable-artifact-builders-for-cardano-stake-distribution branch from ce3bb3a to 9300f1b Compare July 26, 2024 14:41

dlachaume temporarily deployed to testing-preview July 26, 2024 14:49 — with GitHub Actions Inactive

dlachaume temporarily deployed to testing-sanchonet July 26, 2024 14:49 — with GitHub Actions Inactive

dlachaume and others added 7 commits July 26, 2024 16:52

feat: StakeDistributionRetriever as dependency for `CardanoStakeDis…

375cc29

…tributionArtifactBuilder` instead of `StakeStorer` Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>

fix: typo and clarify formulations

cd6edb5

feat: introduced new type representing a stake distribution entry tha…

ab5a2ad

…t is included in the computed merkle tree

feat: apply epoch offset when retrieving the stake distribution for S…

89f3407

…ignable and Artifact builders

feat: apply epoch offset when creating a SignedEntityType from a `T…

0071868

…imePoint`

feat: create dedicated function to get the epoch when the signed enti…

37b9d4d

…ty type is signed Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>

docs: reference the feature in the CHANGELOG

7a98039

dlachaume force-pushed the dlachaume/1832/implement-signable-artifact-builders-for-cardano-stake-distribution branch from 9300f1b to 7a98039 Compare July 26, 2024 14:52

dlachaume temporarily deployed to testing-preview July 26, 2024 14:59 — with GitHub Actions Inactive

dlachaume temporarily deployed to testing-sanchonet July 26, 2024 14:59 — with GitHub Actions Inactive

jpraynaud approved these changes Jul 29, 2024

View reviewed changes

mithril-aggregator/src/http_server/routes/signatures_routes.rs Outdated Show resolved Hide resolved

mithril-common/src/entities/signed_entity_type.rs Outdated Show resolved Hide resolved

sfauvel approved these changes Jul 29, 2024

View reviewed changes

internal/mithril-persistence/src/store/stake_store.rs Outdated Show resolved Hide resolved

mithril-aggregator/src/database/repository/stake_pool_store.rs Outdated Show resolved Hide resolved

mithril-common/src/entities/signed_entity_config.rs Outdated Show resolved Hide resolved

fix: minor changes from PR review comments

54f5e3e

- enhance `list_allowed_signed_entity_types` and `get_epoch_when_signed_entity_type_is_signed` implementations - modify comment in `/register-signatures` route, adding a 'TODO'

dlachaume temporarily deployed to testing-preview July 29, 2024 10:15 — with GitHub Actions Inactive

dlachaume temporarily deployed to testing-sanchonet July 29, 2024 10:15 — with GitHub Actions Inactive

dlachaume added 2 commits July 29, 2024 12:39

feat: move epoch offset responsibility when retrieving a stake distri…

f8b1f0e

…bution to a higher level

chore: bump crates versions

4829708

dlachaume temporarily deployed to testing-preview July 29, 2024 10:46 — with GitHub Actions Inactive

dlachaume temporarily deployed to testing-sanchonet July 29, 2024 10:46 — with GitHub Actions Inactive

dlachaume temporarily deployed to testing-preview July 29, 2024 10:48 — with GitHub Actions Inactive

dlachaume temporarily deployed to testing-sanchonet July 29, 2024 10:48 — with GitHub Actions Inactive

dlachaume temporarily deployed to testing-preview July 29, 2024 10:56 — with GitHub Actions Inactive

dlachaume temporarily deployed to testing-sanchonet July 29, 2024 10:56 — with GitHub Actions Inactive

dlachaume merged commit eaaa3dd into main Jul 29, 2024
40 checks passed

dlachaume deleted the dlachaume/1832/implement-signable-artifact-builders-for-cardano-stake-distribution branch July 29, 2024 12:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement signable and artifact builders for Cardano Stake Distribution #1847

Implement signable and artifact builders for Cardano Stake Distribution #1847

Uh oh!

dlachaume commented Jul 19, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jul 19, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jpraynaud left a comment

Uh oh!

jpraynaud left a comment

Uh oh!

Uh oh!

Uh oh!

sfauvel left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Implement signable and artifact builders for Cardano Stake Distribution #1847

Implement signable and artifact builders for Cardano Stake Distribution #1847

Uh oh!

Conversation

dlachaume commented Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Content

Pre-submit checklist

Issue(s)

Uh oh!

github-actions bot commented Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jpraynaud left a comment

Choose a reason for hiding this comment

Uh oh!

jpraynaud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sfauvel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dlachaume commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024 •

edited

Loading