Skip to content

Handle unparsed blocks in Cardano transactions parser #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 22, 2024
Merged

Handle unparsed blocks in Cardano transactions parser #1641

merged 9 commits into from
Apr 22, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Apr 18, 2024 •
edited
Loading

Content

This PR includes an update that adds a new configuration parameter to the Aggregator and Signer node. It allows to configure the behavior of the Cardano transactions parser with unparsed blocks (return or log the error).

The default value of the new parameter allow_unparsable_block is set to false, which returns an error when a block can't be parsed.
For mainnet and preprod networks, the value is forced to false, even if the parameter is set to true, to always return an error on stable networks.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1567

@dlachaume dlachaume changed the title Handle unparsed blocks in ctx parser Handle unparsed blocks in Cardano transactions parser Apr 18, 2024
@dlachaume dlachaume self-assigned this Apr 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2024 •
edited
Loading

Test Results

    3 files  ±0     43 suites  ±0   8m 19s ⏱️ -47s
  928 tests +4    928 ✅ +4  0 💤 ±0  0 ❌ ±0 
1 022 runs  +4  1 022 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 25c8d02. ± Comparison against base commit 820d937.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-sanchonet April 18, 2024 13:37 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-preview April 18, 2024 14:06 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 18, 2024 14:06 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-preview April 18, 2024 14:36 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 18, 2024 14:36 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the damien/1567/handle-unparsed-blocks-in-ctx-parser branch from 07d9882 to 7df3a7d Compare April 19, 2024 09:19
@dlachaume
feat: implement allow_unparsable_block in cardano_network
a23ffad 
This function evaluate the possibility of validating the request to allow unparsable block or not, depending on the target Cardano network.
@dlachaume
feat: add warning message when allow_unparsable_block is activated
192c803
@dlachaume
feat: make allow_unparsable_block configurable on Signer node
6d1a372 
Add 'allow_unparsable_block' clap argument and Configuration parameter.
@dlachaume
feat: make allow_unparsable_block configurable on Aggregator node
6364a1f 
Add 'allow_unparsable_block' clap argument and Configuration parameter.
@dlachaume
docs: add allow_unparsable_block parameter in Aggregator and Signer…
155bb8d 
… nodes doc
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 19, 2024 09:25 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the damien/1567/handle-unparsed-blocks-in-ctx-parser branch from 7df3a7d to f5a3fd1 Compare April 19, 2024 09:28
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 19, 2024 09:35 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the damien/1567/handle-unparsed-blocks-in-ctx-parser branch from f5a3fd1 to 452058a Compare April 19, 2024 09:36
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 19, 2024 09:42 — with GitHub Actions Inactive
jpraynaud
jpraynaud reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good 👍

@dlachaume dlachaume temporarily deployed to testing-preview April 19, 2024 10:01 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 19, 2024 10:01 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the damien/1567/handle-unparsed-blocks-in-ctx-parser branch from 452058a to 5d06859 Compare April 19, 2024 10:07
@dlachaume dlachaume marked this pull request as ready for review April 19, 2024 10:08
@dlachaume dlachaume requested review from Alenar and sfauvel April 19, 2024 10:09
@dlachaume dlachaume temporarily deployed to testing-preview April 19, 2024 10:13 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 19, 2024 10:13 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-preview April 19, 2024 10:23 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 19, 2024 10:23 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the damien/1567/handle-unparsed-blocks-in-ctx-parser branch from 3f5c96c to 5b6cbcd Compare April 19, 2024 12:22
@dlachaume
refactor: rename function and clarify some comments after review
7467237 
- Rename function 'allow_unparsable_block' to 'compute_allow_unparsable_block' and clarify its comment
- Add reference to pre-production network in 'allow_unparsable_block' comments
@dlachaume
chore: update crates versions
25c8d02
@dlachaume dlachaume force-pushed the damien/1567/handle-unparsed-blocks-in-ctx-parser branch from 5b6cbcd to 25c8d02 Compare April 19, 2024 12:24
jpraynaud
jpraynaud approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume temporarily deployed to testing-preview April 19, 2024 12:31 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 19, 2024 12:31 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit d415b23 into main Apr 22, 2024
41 of 42 checks passed
@dlachaume dlachaume deleted the damien/1567/handle-unparsed-blocks-in-ctx-parser branch April 22, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle unparsed blocks in Cardano transactions parser
3 participants
@dlachaume @Alenar @jpraynaud