Proof generation memory optimisation #1637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
sfauvel
approved these changes
Apr 15, 2024
mithril-aggregator/src/database/repository/cardano_transaction_repository.rs
Outdated
Show resolved
Hide resolved
The goal is to use it to retrieves the transactions to prove instead of walking throught the entire transactions list.
By isolating the prover configuration using a closure.
Instead of finding them by walking the entire transactions list used to create the merkle tree for the proof.
Alenar
force-pushed
the
djo/1629/proof_gen_memory_optimisation
branch
from
0fa371f to
65cb219
Compare
It check that it won't retrieve data that were not asked and won't retrieve data that doesn't exist. + Simplify test & add not exist case to `repository_create_and_get_transaction` as well.
Alenar
force-pushed
the
djo/1629/proof_gen_memory_optimisation
branch
from
65cb219 to
7b252a7
Compare
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
* Mithril-aggregator from `0.4.58` to `0.4.59` * Mithril-common from `0.3.31` `0.3.32`
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR do some memory usage enhancement when computing a proof of Cardano transactions. Nothing ground breaking but this should reduce somehow the maximum memory needed for this operation.
Pre-submit checklist
Issue(s)
Relates to #1629