Use BLST portable feature to enable runtime ADX instruction set check #1630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
force-pushed
the
djo/1614/blst_portable_as_default
branch
from
e56d8e4 to
cb0fc8c
Compare
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
dlachaume
approved these changes
Apr 11, 2024
As blst now check for Intel ADX instruction set at runtime if this feature is enabled (otherwise there's no runtime check).
As it's no longer needed since it does nothing now.
Alenar
force-pushed
the
djo/1614/blst_portable_as_default
branch
3 times, most recently
from
591d0b2 to
c91aeff
Compare
Alenar
force-pushed
the
djo/1614/blst_portable_as_default
branch
from
c91aeff to
7ad18ee
Compare
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR changes the
mithril-stmdependencies in order to always enforce theportablefeatures of BLST.This enable a runtime check of the ADX instruction set instead of the compile time check that we used before, allowing users with older CPUs to use our compiled binaries instead of needing to compile them themselves.
Making this changes make the
mithril-stmportable feature, and all equivalent features in all our crates, useless as it now do strictly nothing.For compatibility purpose, since those crates are published to crates.io, the portable feature is kept on
mithril-stmandmithril-clientbut is removed on the other crates (the CI have been adapted for this change).We should communicate this change to advertise users that depends on our crates.io published crates that this feature will be removed soon.
Pre-submit checklist
Issue(s)
Relates to #1614