Skip to content

Fix 2803 pre-release distribution #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2024
Merged

Fix 2803 pre-release distribution #1447

merged 3 commits into from
Jan 19, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 19, 2024 •
edited
Loading

Content

This PR includes:

  • Fix to npm deployment publish step which was failing
  • Fix to Cardano configuration deployment on the infrastructure that caused Cardano node configurations crash at startup

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Jan 19, 2024
@github-actions GitHub Actions
Copy link

Test Results

  3 files  ±0   33 suites  ±0   9m 21s ⏱️ +52s
760 tests ±0  760 ✅ ±0  0 💤 ±0  0 ❌ ±0 
833 runs  ±0  833 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 509b5c9. ± Comparison against base commit 31cd6e2.

@jpraynaud jpraynaud merged commit 254d266 into main Jan 19, 2024
@jpraynaud jpraynaud deleted the jpraynaud/fix-2803-pre-release-distribution branch January 19, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@dlachaume dlachaume dlachaume approved these changes

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpraynaud @Alenar @dlachaume