Skip to content

Factorize hardcoded keys #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 31, 2023
Merged

Factorize hardcoded keys #1109

merged 7 commits into from
Jul 31, 2023

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Jul 28, 2023 •
edited
Loading

Content

This PR add the fake_keys in the commons to factorize all usage of encoded keys across the code (except for the golden tests were we prefer to specify explicitly everything).

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Issue(s)

Relates to #669

@github-actions
Copy link

github-actions bot commented Jul 28, 2023 •
edited
Loading

Test Results

    3 files  ±0    16 suites  ±0   6m 7s ⏱️ -29s
643 tests +4  643 ✔️ +4  0 💤 ±0  0 ❌ ±0 
681 runs  +4  681 ✔️ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 33e3b11. ± Comparison against base commit 44557d7.

♻️ This comment has been updated with latest results.

@Alenar Alenar temporarily deployed to testing-preview July 28, 2023 10:34 — with GitHub Actions Inactive
@Alenar Alenar force-pushed the ensemble/669/factorize-hardcoded-keys branch from 582ea28 to b7b2291 Compare July 28, 2023 10:35
@Alenar Alenar temporarily deployed to testing-preview July 28, 2023 10:44 — with GitHub Actions Inactive
@Alenar Alenar force-pushed the ensemble/669/factorize-hardcoded-keys branch from b7b2291 to e92cd23 Compare July 28, 2023 11:05
@Alenar Alenar temporarily deployed to testing-preview July 28, 2023 11:13 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-preview July 28, 2023 14:47 — with GitHub Actions Inactive
@Alenar Alenar requested review from ghubertpalo and jpraynaud and removed request for ghubertpalo July 28, 2023 15:28
@Alenar Alenar force-pushed the ensemble/669/factorize-hardcoded-keys branch from 2e1b74d to 5de155b Compare July 28, 2023 15:31
@Alenar Alenar requested review from ghubertpalo and dlachaume July 28, 2023 15:43
@Alenar Alenar marked this pull request as ready for review July 28, 2023 15:43
@Alenar Alenar temporarily deployed to testing-preview July 28, 2023 16:14 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar Alenar temporarily deployed to testing-preview July 31, 2023 07:48 — with GitHub Actions Inactive
@Alenar Alenar merged commit 229d08f into main Jul 31, 2023
@Alenar Alenar deleted the ensemble/669/factorize-hardcoded-keys branch July 31, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

@dlachaume dlachaume Awaiting requested review from dlachaume

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alenar @jpraynaud