Skip to content

Add sign sub-command in aggregator genesis command #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 26, 2023
Merged

Add sign sub-command in aggregator genesis command #1082

merged 5 commits into from
Jul 26, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jul 24, 2023 •
edited
Loading

Content

This PR includes a new sign sub-command in the genesis command.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update documentation website (if relevant)

Issue(s)

Closes #1081

@jpraynaud jpraynaud self-assigned this Jul 24, 2023
@jpraynaud jpraynaud requested review from Alenar and ghubertpalo July 24, 2023 13:28
@github-actions
Copy link

github-actions bot commented Jul 24, 2023 •
edited
Loading

Test Results

    3 files  ±0    16 suites  ±0   7m 0s ⏱️ +40s
640 tests ±0  640 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
678 runs  ±0  678 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b3c67e4. ± Comparison against base commit 456a5ae.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview July 24, 2023 13:39 — with GitHub Actions Inactive
@jpraynaud jpraynaud changed the title Add 'sign' sub-command in aggregator genesis Add sign sub-command in aggregator genesis command Jul 24, 2023
@jpraynaud jpraynaud force-pushed the jpraynaud/1081-add-sign-genesis-sub-command branch from bed0acc to 9f1f880 Compare July 24, 2023 16:52
@jpraynaud jpraynaud temporarily deployed to testing-preview July 24, 2023 17:12 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-preview July 24, 2023 18:00 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-preview July 25, 2023 12:17 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/1081-add-sign-genesis-sub-command branch from f626768 to b3c67e4 Compare July 26, 2023 10:08
@jpraynaud jpraynaud temporarily deployed to testing-preview July 26, 2023 10:17 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 147c49d into main Jul 26, 2023
@jpraynaud jpraynaud deleted the jpraynaud/1081-add-sign-genesis-sub-command branch July 26, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@ghubertpalo ghubertpalo ghubertpalo approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a sign sub-command to genesis command in aggregator
3 participants
@jpraynaud @Alenar @ghubertpalo