Skip to content

Tech writing review #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 18, 2023
Merged

Tech writing review #1061

merged 11 commits into from
Jul 18, 2023

Conversation

olgahryniuk
Copy link
Collaborator

Please consider the reviewed version of the onboarding guide.

This PR includes grammar and IOG style guide edits.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Issue(s)

Relates to #YYY or Closes #YYY

Please consider the reviewed version of the onboarding guide.
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

Could you do the following steps:

  • Fix the few modifications below.
  • Then, replace the docs/root/manual/getting-started/images/spo-onboarding-timeline.png with the one I sent you.
  • Then, replace the docs/versioned_docs/version-maintained/manual/getting-started/images/spo-onboarding-timeline.png with the new docs/root/manual/getting-started/images/spo-onboarding-timeline.png.
  • Then, replace the docs/versioned_docs/version-maintained/manual/getting-started/SPO-on-boarding-guide.md with the new docs/root/manual/getting-started/SPO-on-boarding-guide.md.

Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud merged commit 7949ce3 into input-output-hk:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants