Fix master certificate retrieval #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
force-pushed
the
djo/1006/fix_master_certificate_computation
branch
from
d2bc85a to
a549318
Compare
When querying for a master certificate when a new genesis certificate have been created on an epoch where certificates already existed, the returned certificate would not be the new genesis but the first of the epoch.
Alenar
force-pushed
the
djo/1006/fix_master_certificate_computation
branch
from
a549318 to
e73e2cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR fix master certificate retrieval on a edge case:
If on the queried epoch, epoch with already existing certificates, a genesis certificate is added then the returned certificate when asking the master of that epoch would not be the new genesis but the first certificate of the epoch.
This PR also fix a bad behavior when
CertificateRecordare converted back toCertificate: this would recompute the certificate hash, meaning that the real hash, used as the id of the certificate table, would be lost.Pre-submit checklist
Issue(s)
Closes #1006