Create a mithril-resource-pool module

Author: sfauvel

Cargo.lock

@@ -13,6 +13,7 @@ members = [
   "internal/mithril-doc-derive",
   "internal/mithril-metric",
   "internal/mithril-persistence",
+  "internal/mithril-resource-pool",
   "mithril-aggregator",
   "mithril-client",
   "mithril-client-cli",

Cargo.toml

@@ -17,6 +17,7 @@ async-trait = "0.1.86"
 chrono = { version = "0.4.39", features = ["serde"] }
 hex = "0.4.3"
 mithril-common = { path = "../../mithril-common", features = ["fs"] }
+mithril-resource-pool = { path = "../mithril-resource-pool" }
 semver = "1.0.25"
 serde = { version = "1.0.217", features = ["derive"] }
 serde_json = "1.0.138"

internal/mithril-persistence/Cargo.toml

@@ -1,9 +1,7 @@
 use std::{ops::Deref, time::Duration};
 
-use mithril_common::{
-    resource_pool::{Reset, ResourcePool, ResourcePoolItem},
-    StdResult,
-};
+use mithril_common::{Reset, StdResult};
+use mithril_resource_pool::{ResourcePool, ResourcePoolItem};
 
 use crate::sqlite::SqliteConnection;
 

internal/mithril-persistence/src/sqlite/connection_pool.rs

@@ -0,0 +1,23 @@
+[package]
+name = "mithril-resource-pool"
+version = "0.0.1"
+description = "Provide a resource pool for Mithril."
+authors = { workspace = true }
+edition = { workspace = true }
+homepage = { workspace = true }
+license = { workspace = true }
+repository = { workspace = true }
+
+[lib]
+crate-type = ["lib", "cdylib", "staticlib"]
+
+[dependencies]
+anyhow = "1.0.95"
+mithril-common = { path = "../../mithril-common", features = ["fs"] }
+thiserror = "2.0.11"
+tokio = { version = "1.43.0", features = ["sync"] }
+
+[dev-dependencies]
+mithril-common = { path = "../../mithril-common", features = ["test_tools"] }
+mockall = "0.13.1"
+tokio = { version = "1.43.0", features = ["macros", "time"] }

internal/mithril-resource-pool/Cargo.toml

@@ -0,0 +1,19 @@
+.PHONY: all build test check doc
+
+CARGO = cargo
+
+all: test build
+
+build:
+	${CARGO} build --release
+
+test:
+	${CARGO} test
+
+check:
+	${CARGO} check --release --all-features --all-targets
+	${CARGO} clippy --release --all-features --all-targets
+	${CARGO} fmt --check
+
+doc:
+	${CARGO} doc --no-deps --open --features full

internal/mithril-resource-pool/Makefile

@@ -0,0 +1,3 @@
+# Mithril-resource-pool
+
+This crate provide a resource pool for Mithril.

internal/mithril-resource-pool/README.md

@@ -0,0 +1,7 @@
+#![warn(missing_docs)]
+
+//! Provide a resource pool for Mithril.
+
+mod resource_pool;
+
+pub use resource_pool::*;

internal/mithril-resource-pool/src/lib.rs

@@ -9,7 +9,7 @@ use std::{
 };
 use thiserror::Error;
 
-use crate::StdResult;
+use mithril_common::{Reset, StdResult};
 
 /// [ResourcePool] related errors.
 #[derive(Error, Debug)]
@@ -207,20 +207,6 @@ impl<T: Reset + Send + Sync> Drop for ResourcePoolItem<'_, T> {
     }
 }
 
-/// Reset trait which is implemented by pooled resource items.
-/// As pool resource items are mutable, this will guarantee that the pool stays  consistent
-/// and that acquired resource items do not depend from previous computations.
-pub trait Reset {
-    /// Reset the resource
-    fn reset(&mut self) -> StdResult<()> {
-        Ok(())
-    }
-}
-
-cfg_test_tools! {
-    impl Reset for String {}
-}
-
 #[cfg(test)]
 mod tests {
     use std::time::Duration;

mithril-common/src/resource_pool.rs renamed to internal/mithril-resource-pool/src/resource_pool.rs

@@ -30,6 +30,7 @@ mithril-common = { path = "../mithril-common", features = ["full"] }
 mithril-doc = { path = "../internal/mithril-doc" }
 mithril-metric = { path = "../internal/mithril-metric" }
 mithril-persistence = { path = "../internal/mithril-persistence" }
+mithril-resource-pool = { path = "../internal/mithril-resource-pool" }
 paste = "1.0.15"
 prometheus = "0.13.4"
 rayon = "1.10.0"