Skip to content

ETCM-986 Remove method storeEvmCode from Blockchain #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

leo-bogastry
Copy link
Contributor

Description

Remove method storeEvmCode from Blockchain class and use EvmCodestorage direclty

Proposed Solution

The method "storeEvmCode" just makes a direct call to the EvmStorage and is only used by a class and a couple of test classes

The code will be modified to have the EvmStorage called directly

Copy link
Contributor

@jvdp jvdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@leo-bogastry leo-bogastry merged commit c538465 into develop Jul 7, 2021
@leo-bogastry leo-bogastry deleted the refactor/ETCM-986-storeEvmCode branch July 7, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants