Allow reinstall of filepath in GHC 9.4.8 #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A cabal flag (`vendor-filepath`) was used to avoid the `template-haskell` dependency on `filepath` in the version of `template-haskell` (2.19.0.0) used by `ghc` 9.4.8.
```
if flag(vendor-filepath)
other-modules:
System.FilePath
System.FilePath.Posix
System.FilePath.Windows
hs-source-dirs: ./vendored-filepath .
default-extensions:
ImplicitPrelude
else
build-depends: filepath
hs-source-dirs: .
```
The `dummy-ghc` code in haskell.nix does not evaluate conditionals (instead it just includes all of the dependencies. This leads to issues where the planner is unable to come up with a plan because it thinks `filepath` cannot be reinstalled.
This fix works around the by hard coding a rule for `vendor-filepath`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cabal flag (
vendor-filepath) was used to avoid thetemplate-haskelldependency onfilepathin the version oftemplate-haskell(2.19.0.0) used byghc9.4.8.The
dummy-ghccode in haskell.nix does not evaluate conditionals (instead it just includes all of the dependencies. This leads to issues where the planner is unable to come up with a plan because it thinksfilepathcannot be reinstalled.This fix works around the by hard coding a rule for
vendor-filepath.