Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set arch-native: False for hashable >= 1.4.5.0 #2213

Open
TerrorJack opened this issue Jun 9, 2024 · 3 comments
Open

Set arch-native: False for hashable >= 1.4.5.0 #2213

TerrorJack opened this issue Jun 9, 2024 · 3 comments
Labels
enhancement New feature or request wontfix

Comments

@TerrorJack
Copy link
Contributor

hashable-1.4.5.0 has been released recently and has already been included in the last hackage.nix and stackage nightly revision. This package now vendors xxhash and includes a package flag arch-native to pass -march=native to C compiler to harvest SIMD speedup. And arch-native defaults to True, which will cause the nix build artifacts to silently depend on CPU models of the nix builders, causing potential run-time crash on machines with older CPU models and breaking nix build purity silently.

I believe haskell.nix has hackage-quirks.nix that enables overriding default package flags for hackage packages, and arch-native: False should be enforced for hashable >= 1.4.5.0.

Related upstream issue (closed by maintainer): haskell-unordered-containers/hashable#308

@TerrorJack TerrorJack added the enhancement New feature or request label Jun 9, 2024
@TerrorJack
Copy link
Contributor Author

This might be a non-issue, see NixOS/nixpkgs#318321 (comment), feel free to close this one, though it would be better if someone familiar with nixpkgs internal to actually confirm.

@hamishmack
Copy link
Collaborator

If we need to add this configuration-nix.nix would be the place to put it.

Copy link

stale bot commented Oct 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix
Projects
None yet
Development

No branches or pull requests

2 participants