Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update sign tool v2 using new catalyst-voting crate | NPG-000 #718

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Oct 17, 2024

Description

Updated sign tool with the new cli command v2 which generates the VoteCast jorm fragment using the new catalyst-voting crate https://github.com/input-output-hk/catalyst-libs/tree/main/rust/catalyst-voting.

This PR updates the interface of the sign cli tool to have a few command options:

  • sign v1 ... original jorm implementation.
  • sign v2 ... using new catalyst-voting crate.

The rest of the passing arguments remains the same

Closes #717

@Mr-Leshiy Mr-Leshiy changed the title sign tool v2 using new catalyst-voting crate feat: sign tool v2 using new catalyst-voting crate Oct 17, 2024
@Mr-Leshiy Mr-Leshiy changed the title feat: sign tool v2 using new catalyst-voting crate feat: Update sign tool v2 using new catalyst-voting crate Oct 17, 2024
@Mr-Leshiy Mr-Leshiy changed the title feat: Update sign tool v2 using new catalyst-voting crate feat: Update sign tool v2 using new catalyst-voting crate | NPG-000 Oct 17, 2024
@Mr-Leshiy Mr-Leshiy marked this pull request as ready for review October 17, 2024 11:30
@Mr-Leshiy Mr-Leshiy marked this pull request as draft October 17, 2024 11:30
@Mr-Leshiy Mr-Leshiy self-assigned this Oct 17, 2024
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Oct 17, 2024
Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sign tool to be able to build transaction using catalyst-voting crate
2 participants