Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Observability improvements to node logs and metrics | NPG-7984 #542

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

saibatizoku
Copy link
Contributor

Description

Update a couple of log messages to clarify fragments rejected from the mempool.
Convert lastBlockTx prometheus metric from being a gauge into counter.
Add docstrings to clarify the meaning of prometheus metrics related to transactions.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saibatizoku saibatizoku added the review me PR is ready for review label Aug 29, 2023
@saibatizoku saibatizoku requested review from jmgilman and a team August 29, 2023 16:13
@saibatizoku saibatizoku self-assigned this Aug 29, 2023
@saibatizoku saibatizoku force-pushed the chore/tracing-spans-for-mempool branch from f0e43ff to b2728c8 Compare August 29, 2023 16:15
@saibatizoku saibatizoku enabled auto-merge (squash) August 29, 2023 17:24
Copy link
Contributor

@FelipeRosa FelipeRosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saibatizoku saibatizoku merged commit 79165d5 into main Aug 29, 2023
27 checks passed
@saibatizoku saibatizoku deleted the chore/tracing-spans-for-mempool branch August 29, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants