fix(catalyst-toolbox): Count missing voting power | NPG-0000

[stevenj]

Description

Catalyst toolbox snapshot and sve-snapshot commands were both (with different code paths) excluding individual registrations with < threshold ada voting power.

This meant that multiple registrations to the same voting key would have missing voting power if any of those individual registrations were < the threshold. This change does that check only on the cumulative total of all voting power.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The utilities/snapshot-check/snapshot-check.py was sued to validate the voting power is properly being calculated.
The utilities/snapshot-check/compar_snapshot.py was used to compare a full processed snapshot with an SVE one.

Old snapshots fail to validate, new ones after these changes validate correctly.

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[minikin]

LGTM