migrate build to version catalog (ExpediaGroup#1630)

* migrate build to version catalog

[Version Catalog](https://docs.gradle.org/current/userguide/platforms.html#sub:version-catalog) is a preferred mechanism for declaring and sharing project dependencies. Once dependencies are defined in the `libs.versions.toml` file, they can be imported using type safe accessors.

Dependent projects (i.e. `examples`, Gradle plugin integration tests and federation compatibility) can also import same version catalog which further simplifies version management.

* configure examples to use version catalog

* ktlint fix

Author: dariuszkuc

build.gradle.kts

@@ -37,15 +37,7 @@ allprojects {
 }
 
 subprojects {
-    val kotlinxCoroutinesVersion: String by project
     val kotlinJvmVersion: String by project
-    val kotlinVersion: String by project
-    val junitVersion: String by project
-    val mockkVersion: String by project
-
-    val detektVersion: String by project
-    val ktlintVersion: String by project
-    val jacocoVersion: String by project
 
     val currentProject = this
 
@@ -70,14 +62,14 @@ subprojects {
             dependsOn(jacocoTestCoverageVerification)
         }
         detekt {
-            toolVersion = detektVersion
+            toolVersion = rootProject.project.libs.versions.detekt.get()
             config = files("${rootProject.projectDir}/detekt.yml")
         }
         ktlint {
-            version.set(ktlintVersion)
+            version.set(rootProject.project.libs.versions.ktlint.core.get())
         }
         jacoco {
-            toolVersion = jacocoVersion
+            toolVersion = rootProject.project.libs.versions.jacoco.get()
         }
         jar {
             manifest {
@@ -178,15 +170,16 @@ subprojects {
         }
     }
 
+    // typesafe accessors to version catalog do not work in the subprojects/allprojects block, need to use rootProject.project
     dependencies {
-        implementation(kotlin("stdlib", kotlinVersion))
-        implementation(kotlin("reflect", kotlinVersion))
-        implementation("org.jetbrains.kotlinx:kotlinx-coroutines-jdk8:$kotlinxCoroutinesVersion")
-        testImplementation(kotlin("test", kotlinVersion))
-        testImplementation(kotlin("test-junit5", kotlinVersion))
-        testImplementation("org.junit.jupiter:junit-jupiter-api:$junitVersion")
-        testImplementation("org.junit.jupiter:junit-jupiter-engine:$junitVersion")
-        testImplementation("io.mockk:mockk:$mockkVersion")
+        implementation(rootProject.project.libs.kotlin.stdlib)
+        implementation(rootProject.project.libs.kotlin.reflect)
+        implementation(rootProject.project.libs.kotlinx.coroutines.jdk8)
+        testImplementation(rootProject.project.libs.kotlin.test)
+        testImplementation(rootProject.project.libs.kotlin.junit.test)
+        testImplementation(rootProject.project.libs.junit.api)
+        testImplementation(rootProject.project.libs.junit.engine)
+        testImplementation(rootProject.project.libs.mockk)
     }
 }
 

clients/graphql-kotlin-client-jackson/build.gradle.kts

@@ -1,10 +1,8 @@
 description = "GraphQL client serializer based on Jackson"
 
-val jacksonVersion: String by project
-
 dependencies {
     api(project(path = ":graphql-kotlin-client"))
-    api("com.fasterxml.jackson.module:jackson-module-kotlin:$jacksonVersion")
+    api(libs.jackson)
 }
 
 tasks {

clients/graphql-kotlin-client-serialization/build.gradle.kts

@@ -4,13 +4,10 @@ plugins {
     kotlin("plugin.serialization")
 }
 
-val kotlinxCoroutinesVersion: String by project
-val kotlinxSerializationVersion: String by project
-
 dependencies {
     api(project(path = ":graphql-kotlin-client"))
-    api("org.jetbrains.kotlinx:kotlinx-coroutines-core:$kotlinxCoroutinesVersion")
-    api("org.jetbrains.kotlinx:kotlinx-serialization-json:$kotlinxSerializationVersion")
+    api(libs.kotlinx.coroutines.core)
+    api(libs.kotlinx.serialization.json)
 }
 
 tasks {

clients/graphql-kotlin-client/build.gradle.kts

@@ -1,7 +1,5 @@
 description = "A lightweight typesafe GraphQL HTTP Client"
 
-val kotlinxCoroutinesVersion: String by project
-
 dependencies {
-    api("org.jetbrains.kotlinx:kotlinx-coroutines-core:$kotlinxCoroutinesVersion")
+    api(libs.kotlinx.coroutines.core)
 }

clients/graphql-kotlin-ktor-client/build.gradle.kts

@@ -4,18 +4,15 @@ plugins {
     kotlin("plugin.serialization")
 }
 
-val ktorVersion: String by project
-val wireMockVersion: String by project
-
 dependencies {
     api(project(path = ":graphql-kotlin-client"))
     api(project(path = ":graphql-kotlin-client-serialization"))
-    api("io.ktor:ktor-client-cio:$ktorVersion")
-    api("io.ktor:ktor-client-serialization:$ktorVersion")
+    api(libs.ktor.client.cio)
+    api(libs.ktor.client.serialization)
     testImplementation(project(path = ":graphql-kotlin-client-jackson"))
-    testImplementation("io.ktor:ktor-client-okhttp:$ktorVersion")
-    testImplementation("io.ktor:ktor-client-logging:$ktorVersion")
-    testImplementation("com.github.tomakehurst:wiremock-jre8:$wireMockVersion")
+    testImplementation(libs.ktor.client.logging)
+    testImplementation(libs.ktor.client.okhttp)
+    testImplementation(libs.wiremock.jre8)
 }
 
 tasks {

clients/graphql-kotlin-spring-client/build.gradle.kts

@@ -4,19 +4,14 @@ plugins {
     kotlin("plugin.serialization")
 }
 
-val kotlinxCoroutinesVersion: String by project
-val springVersion: String by project
-val springBootVersion: String by project
-val wireMockVersion: String by project
-
 dependencies {
     api(project(path = ":graphql-kotlin-client"))
     api(project(path = ":graphql-kotlin-client-jackson"))
-    api("org.jetbrains.kotlinx:kotlinx-coroutines-reactor:$kotlinxCoroutinesVersion")
-    api("org.springframework:spring-webflux:$springVersion")
-    api("org.springframework.boot:spring-boot-starter-reactor-netty:$springBootVersion")
+    api(libs.kotlinx.coroutines.reactor)
+    api(libs.spring.webflux)
+    api(libs.spring.boot.netty)
     testImplementation(project(path = ":graphql-kotlin-client-serialization"))
-    testImplementation("com.github.tomakehurst:wiremock-jre8:$wireMockVersion")
+    testImplementation(libs.wiremock.jre8)
 }
 
 tasks {

examples/build.gradle.kts

@@ -35,26 +35,18 @@ subprojects {
         this.ext[key.toString()] = value
     }
 
-    val icuVersion: String by project
-    val junitVersion: String by project
-    val kotlinVersion: String by project
-    val kotlinxCoroutinesVersion: String by project
-
-    val detektVersion: String by project
-    val ktlintVersion: String by project
-
     apply(plugin = "kotlin")
     apply(plugin = "io.gitlab.arturbosch.detekt")
     apply(plugin = "org.jlleitschuh.gradle.ktlint")
 
     dependencies {
-        implementation(kotlin("stdlib", kotlinVersion))
-        implementation(kotlin("reflect", kotlinVersion))
-        implementation("org.jetbrains.kotlinx:kotlinx-coroutines-jdk8:$kotlinxCoroutinesVersion")
-        implementation("com.ibm.icu:icu4j:$icuVersion")
-        testImplementation(kotlin("test-junit5", kotlinVersion))
-        testImplementation("org.junit.jupiter:junit-jupiter-api:$junitVersion")
-        testImplementation("org.junit.jupiter:junit-jupiter-engine:$junitVersion")
+        implementation(rootProject.project.libs.kotlin.stdlib)
+        implementation(rootProject.project.libs.kotlin.reflect)
+        implementation(rootProject.project.libs.kotlinx.coroutines.jdk8)
+        implementation(rootProject.project.libs.icu)
+        testImplementation(rootProject.project.libs.kotlin.junit.test)
+        testImplementation(rootProject.project.libs.junit.api)
+        testImplementation(rootProject.project.libs.junit.engine)
     }
 
     tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
@@ -66,11 +58,11 @@ subprojects {
 
     tasks {
         detekt {
-            toolVersion = detektVersion
+            toolVersion = rootProject.project.libs.versions.detekt.get()
             config = files(File(rootDir.parent, "detekt.yml").absolutePath)
         }
         ktlint {
-            version.set(ktlintVersion)
+            version.set(rootProject.project.libs.versions.ktlint.core.get())
         }
         jar {
             enabled = false

examples/client/build.gradle.kts

@@ -2,10 +2,8 @@ import com.github.tomakehurst.wiremock.standalone.WireMockServerRunner
 import java.net.ServerSocket
 
 buildscript {
-    // cannot access project at this time
-    val wireMockVersion: String = "2.26.2"
     dependencies {
-        classpath("com.github.tomakehurst:wiremock-jre8-standalone:$wireMockVersion")
+        classpath(libs.wiremock.standalone)
     }
 }
 

examples/client/gradle-client/build.gradle.kts

@@ -13,8 +13,8 @@ plugins {
 val ktorVersion: String by project
 dependencies {
     implementation("com.expediagroup", "graphql-kotlin-ktor-client")
-    implementation("io.ktor:ktor-client-okhttp:$ktorVersion")
-    implementation("io.ktor:ktor-client-logging-jvm:$ktorVersion")
+    implementation(libs.ktor.client.okhttp)
+    implementation(libs.ktor.client.jvm.logging)
 }
 
 application {

examples/client/maven-client/build.gradle.kts

@@ -2,23 +2,19 @@ import java.time.Duration
 
 description = "Example usage of Maven plugin to generate GraphQL Kotlin Client"
 
-val kotlinJvmVersion: String by project
-val kotlinVersion: String by project
-val kotlinxCoroutinesVersion: String by project
-val reactorVersion: String by project
-
 dependencies {
     implementation("com.expediagroup", "graphql-kotlin-spring-client")
 }
 
 tasks {
+    val kotlinJvmVersion: String by project
     /* Gradle is used to invoke maven wrapper */
     val mavenEnvironmentVariables = mapOf(
         "graphqlKotlinVersion" to project.version,
         "kotlinJvmTarget" to kotlinJvmVersion,
-        "kotlinVersion" to kotlinVersion,
-        "kotlinxCoroutinesVersion" to kotlinxCoroutinesVersion,
-        "reactorVersion" to reactorVersion
+        "kotlinVersion" to libs.versions.kotlin.get(),
+        "kotlinxCoroutinesVersion" to libs.versions.kotlinx.coroutines.get(),
+        "reactorVersion" to libs.versions.reactor.core.get()
     )
     val wireMockServerPort: Int? = ext.get("wireMockServerPort") as? Int
     val mavenBuild by register("mavenBuild") {

examples/federation/products-subgraph/build.gradle.kts

@@ -6,10 +6,9 @@ plugins {
     id("com.expediagroup.graphql")
 }
 
-val springBootVersion: String by project
 dependencies {
     implementation("com.expediagroup", "graphql-kotlin-spring-server")
-    testImplementation("org.springframework.boot", "spring-boot-starter-test", springBootVersion)
+    testImplementation(libs.spring.boot.test)
 
     graphqlSDL("com.expediagroup", "graphql-kotlin-federated-hooks-provider")
 }

examples/federation/reviews-subgraph/build.gradle.kts

@@ -6,10 +6,9 @@ plugins {
     id("com.expediagroup.graphql")
 }
 
-val springBootVersion: String by project
 dependencies {
     implementation("com.expediagroup", "graphql-kotlin-spring-server")
-    testImplementation("org.springframework.boot", "spring-boot-starter-test", springBootVersion)
+    testImplementation(libs.spring.boot.test)
 
     graphqlSDL("com.expediagroup", "graphql-kotlin-federated-hooks-provider")
 }

examples/server/ktor-server/build.gradle.kts

@@ -9,16 +9,12 @@ application {
     mainClass.set("io.ktor.server.netty.EngineMain")
 }
 
-val kotlinxCoroutinesVersion: String by project
-val ktorVersion: String by project
-val logbackVersion: String by project
-
 dependencies {
     implementation("com.expediagroup", "graphql-kotlin-server")
-    implementation("io.ktor", "ktor-server-core", ktorVersion)
-    implementation("io.ktor", "ktor-server-netty", ktorVersion)
-    implementation("ch.qos.logback", "logback-classic", logbackVersion)
-    implementation("org.jetbrains.kotlinx", "kotlinx-coroutines-jdk8", kotlinxCoroutinesVersion)
+    implementation(libs.ktor.server.core)
+    implementation(libs.ktor.server.netty)
+    implementation(libs.logback)
+    implementation(libs.kotlinx.coroutines.jdk8)
 }
 
 graphql {

examples/server/ktor-server/gradle.properties

@@ -6,15 +6,12 @@ plugins {
     id("com.expediagroup.graphql")
 }
 
-val springBootVersion: String by project
-val reactorVersion: String by project
-
 dependencies {
     implementation("com.expediagroup", "graphql-kotlin-spring-server")
     implementation("com.expediagroup", "graphql-kotlin-hooks-provider")
-    implementation("org.springframework.boot", "spring-boot-starter-validation", springBootVersion)
-    testImplementation("org.springframework.boot:spring-boot-starter-test:$springBootVersion")
-    testImplementation("io.projectreactor:reactor-test:$reactorVersion")
+    implementation(libs.spring.boot.validation)
+    testImplementation(libs.spring.boot.test)
+    testImplementation(libs.reactor.test)
 }
 
 graphql {

examples/server/spring-server/build.gradle.kts

@@ -1,3 +1,18 @@
+dependencyResolutionManagement {
+    versionCatalogs {
+        create("libs") {
+            from(files("../gradle/libs.versions.toml"))
+
+            // examples specific libs
+            library("ktor-client-jvm-logging", "io.ktor", "ktor-client-logging-jvm").versionRef("ktor")
+            library("ktor-server-core", "io.ktor", "ktor-server-core").versionRef("ktor")
+            library("ktor-server-netty", "io.ktor", "ktor-server-netty").versionRef("ktor")
+            library("logback", "ch.qos.logback", "logback-classic").version("1.2.1")
+            library("spring-boot-validation", "org.springframework.boot", "spring-boot-starter-validation").versionRef("spring-boot")
+        }
+    }
+}
+
 pluginManagement {
     val properties = java.util.Properties()
     properties.load(File(rootDir.parent, "gradle.properties").inputStream())

examples/settings.gradle.kts

@@ -1,12 +1,7 @@
 description = "Automatic Persisted Queries"
 
-val junitVersion: String by project
-val graphQLJavaVersion: String by project
-
 dependencies {
-    api("com.graphql-java:graphql-java:$graphQLJavaVersion")
-    testImplementation("org.junit.jupiter:junit-jupiter-api:$junitVersion")
-    testImplementation("org.junit.jupiter:junit-jupiter-engine:$junitVersion")
+    api(libs.graphql.java)
 }
 
 tasks {

executions/graphql-kotlin-automatic-persisted-queries/build.gradle.kts

@@ -1,19 +1,12 @@
 description = "Data Loader Instrumentations"
 
-val junitVersion: String by project
-val graphQLJavaVersion: String by project
-val reactorVersion: String by project
-val reactorExtensionsVersion: String by project
-
 dependencies {
     api(project(path = ":graphql-kotlin-dataloader"))
-    api("com.graphql-java:graphql-java:$graphQLJavaVersion") {
+    api(libs.graphql.java) {
         exclude(group = "com.graphql-java", module = "java-dataloader")
     }
-    testImplementation("io.projectreactor.kotlin:reactor-kotlin-extensions:$reactorExtensionsVersion")
-    testImplementation("io.projectreactor:reactor-core:$reactorVersion")
-    testImplementation("org.junit.jupiter:junit-jupiter-api:$junitVersion")
-    testImplementation("org.junit.jupiter:junit-jupiter-engine:$junitVersion")
+    testImplementation(libs.reactor.core)
+    testImplementation(libs.reactor.extensions)
 }
 
 tasks {

executions/graphql-kotlin-dataloader-instrumentation/build.gradle.kts

@@ -1,16 +1,9 @@
 description = "Graphql Kotlin Data Loader"
 
-val junitVersion: String by project
-val graphQLJavaDataLoaderVersion: String by project
-val reactorVersion: String by project
-val reactorExtensionsVersion: String by project
-
 dependencies {
-    api("com.graphql-java:java-dataloader:$graphQLJavaDataLoaderVersion")
-    testImplementation("io.projectreactor.kotlin:reactor-kotlin-extensions:$reactorExtensionsVersion")
-    testImplementation("io.projectreactor:reactor-core:$reactorVersion")
-    testImplementation("org.junit.jupiter:junit-jupiter-api:$junitVersion")
-    testImplementation("org.junit.jupiter:junit-jupiter-engine:$junitVersion")
+    api(libs.dataloader)
+    testImplementation(libs.reactor.core)
+    testImplementation(libs.reactor.extensions)
 }
 
 tasks {