feat: ERC20 enters #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
motivation for this commit deb8511 : i wanted to not touch the token admin key(s) whenever possible, so it seemed nice to be able to configure the contract at deploy time without having to activate that multisig it would be cleaner to configure the contract via scripts as we do with sequencer keys, but this seemed on balance better 🤔 |
prestwich
reviewed
Jul 1, 2024
| @@ -114,15 +153,27 @@ contract Passage { | |||
| emit Transact(rollupChainId, msg.sender, to, data, value, gas, maxFeePerGas); | |||
| } | |||
|
|
|||
| /// @notice Alow/Disallow a given ERC20 token to enter the rollup. | |||
| function configureEnter(address token, bool _canEnter) external { | |||
| if (msg.sender != tokenAdmin) revert OnlyTokenAdmin(); | |||
There was a problem hiding this comment.
followup work:
bump solidity to 0.8.26 so we can use require(_, Error) instead of if-revert
There was a problem hiding this comment.
prestwich
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enterTokenfunction + eventEnterToken(address token)eventconfigureEnterevent +canEntervar