-
Notifications
You must be signed in to change notification settings - Fork 0
feat: updates bundle prep to track the rollup tx hash #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/tasks/submit/flashbots.rs
Outdated
| /// 2. Tracking the transaction hash for monitoring | ||
| /// 3. Encoding the transaction for bundle inclusion | ||
| /// 4. Constructing the complete bundle body | ||
| async fn prepare_bundle_helper(&self, sim_result: &SimResult) -> eyre::Result<MevSendBundle> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BundleHelper contract is dead. we should delete this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to replace it with a direct call to zenith
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh it looks like this was done, but the function name and docs need to be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the function name -> prepare_bundle and removed all mentions of the BuilderHelper from the README.
- removes mentions of BuilderHelper contract and config - removes deprecated variables around builder helper and chain configs - adds documentation for latest flashbots related configs
157b10a to
25ed5fb
Compare
src/tasks/submit/flashbots.rs
Outdated
| /// 2. Tracking the transaction hash for monitoring | ||
| /// 3. Encoding the transaction for bundle inclusion | ||
| /// 4. Constructing the complete bundle body | ||
| async fn prepare_bundle_helper(&self, sim_result: &SimResult) -> eyre::Result<MevSendBundle> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the function name -> prepare_bundle and removed all mentions of the BuilderHelper from the README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive by changes: ppdated the README to match latest env config changes re: signet system constants usage, Flashbots updates, chain name, etc...

feat: updates bundle prep to track the rollup tx hash
This PR updates the bundle preparation functions to track the rollup block's transaction hash through to landing on chain.
There are also some drive-by refactors and doc updates to the bundle prep loop and documentation surrounding env var configuration.