chore(tracing): improve bundle tracing, break when receiver is dropped #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
prestwich
approved these changes
Jun 19, 2025
Evalir
force-pushed
the
evalir/logging-bundle-improvements
branch
from
4905988 to
839dc47
Compare
| { | ||
| let _guard = span.entered(); | ||
| debug!(count = ?bundles.len(), "found bundles"); | ||
| for bundle in bundles.into_iter() { |
Contributor
There was a problem hiding this comment.
could we add a trace or debug log for the bundle id of each bundle?
Member
There was a problem hiding this comment.
that should be done in the cache on ingestion, rather than here
prestwich
reviewed
Jun 20, 2025
src/tasks/cache/task.rs
Outdated
| } | ||
|
|
||
| /// Utility to log a bundle and its contents. | ||
| fn log_bundle(bundle: &TxCacheBundle) { |
Member
There was a problem hiding this comment.
per discussion, these events should live in the SDK in SimCache::ingest
I also think these are too verbose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ENG-1159