Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update .gitignore to exclude nats; add nats script #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matoszz
Copy link

@matoszz matoszz commented Jul 11, 2023

Inside of this repository and docker compose there are references to NATs scripts which do not exist and fail to initialize when attempting to use the devcontainer or compose. This PR adds the missing scripts as well as updates the .gitignore to exclude the generated NATs configuration

@matoszz matoszz requested review from a team as code owners July 11, 2023 01:48
Signed-off-by: Matthew Anderson <42154938+matoszz@users.noreply.github.com>
@@ -0,0 +1,15 @@
// Operator "LOCAL"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need this, its generated by the nats_init.sh script you have added


export ACCOUNTS_SIGNING_KEY_ID=`nsc describe account LOC -J | jq -r '.nats.signing_keys | first'`

echo "Creating NATS user for location-api"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo "Creating NATS user for location-api"
echo "Creating NATS user for example-api"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants