Skip to content

Commit a0be6eb

Browse files
sershe-apacheApache9
authored andcommitted
HBASE-22354 master never sets abortRequested, and thus abort timeout doesn't work for it
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
1 parent 821ff95 commit a0be6eb

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2954,6 +2954,7 @@ public void abort(String reason, Throwable cause) {
29542954
if (isAborted() || isStopped()) {
29552955
return;
29562956
}
2957+
setAbortRequested();
29572958
if (cpHost != null) {
29582959
// HBASE-4014: dump a list of loaded coprocessors.
29592960
LOG.error(HBaseMarkers.FATAL, "Master server abort: loaded coprocessors are: " +

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2415,7 +2415,7 @@ public void abort(String reason, Throwable cause) {
24152415
} else {
24162416
LOG.error(HBaseMarkers.FATAL, msg);
24172417
}
2418-
this.abortRequested = true;
2418+
setAbortRequested();
24192419
// HBASE-4014: show list of coprocessors that were loaded to help debug
24202420
// regionserver crashes.Note that we're implicitly using
24212421
// java.util.HashSet's toString() method to print the coprocessor names.
@@ -2449,6 +2449,10 @@ public void abort(String reason, Throwable cause) {
24492449
stop(reason, true, null);
24502450
}
24512451

2452+
protected final void setAbortRequested() {
2453+
this.abortRequested = true;
2454+
}
2455+
24522456
/**
24532457
* @see HRegionServer#abort(String, Throwable)
24542458
*/

0 commit comments

Comments
 (0)