-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSS Toggle to header menu. #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎 Nice showcase.
Makes sense to keep this a separate plug-in, as I doubt most users of the main DITA Bootstrap one would need it (and those who do can install it separately).
No strong opinion here on whether to release it under the net.infotexture
namespace or under fox.jason
, but either way we should clean up the plug-in ID & name references to be consistent.
As for the name, I wonder if css-toggle
is at all misleading. It does change CSS files, but since each of them is a Bootswatch theme, I wonder if something like theme-switcher
would be clearer.
When I tested on https://jason-fox.github.io/dita-bootstrap/, selecting different themes from the menu did not seem to change anything.
Within this PR, we should probably append a note below the themes carousel on the landing page, to point out that you can try them out live.
Changed to
Bug fixed.
Note added d892459 |
Signed-off-by: Roger Sheen <roger@infotexture.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good (and works).
Tweaked the copy in the new note, merging…
Add a mechanism to showcase all of the Bootswatch themes.
working example: https://jason-fox.github.io/dita-bootstrap/
This is just another small plugin: https://github.com/jason-fox/dita-bootstrap.css-toggle to host a single JavaScript file, but CSS Switching is so niche that it doesn't really need to be in the main Bootstrap plugin.
If you want I could transfer the repo to keep all the
dita-bootstrap
stuff together then I'd be happy to push it over.