Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS Toggle to header menu. #145

Merged
merged 13 commits into from
Nov 30, 2023

Conversation

jason-fox
Copy link
Collaborator

Add a mechanism to showcase all of the Bootswatch themes.

Screenshot 2023-11-25 at 11 54 54

working example: https://jason-fox.github.io/dita-bootstrap/

This is just another small plugin: https://github.com/jason-fox/dita-bootstrap.css-toggle to host a single JavaScript file, but CSS Switching is so niche that it doesn't really need to be in the main Bootstrap plugin.

If you want I could transfer the repo to keep all the dita-bootstrap stuff together then I'd be happy to push it over.

Copy link
Owner

@infotexture infotexture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎 Nice showcase.

Makes sense to keep this a separate plug-in, as I doubt most users of the main DITA Bootstrap one would need it (and those who do can install it separately).

No strong opinion here on whether to release it under the net.infotexture namespace or under fox.jason, but either way we should clean up the plug-in ID & name references to be consistent.

As for the name, I wonder if css-toggle is at all misleading. It does change CSS files, but since each of them is a Bootswatch theme, I wonder if something like theme-switcher would be clearer.

When I tested on https://jason-fox.github.io/dita-bootstrap/, selecting different themes from the menu did not seem to change anything.

Within this PR, we should probably append a note below the themes carousel on the landing page, to point out that you can try them out live.

@jason-fox
Copy link
Collaborator Author

I wonder if css-toggle is at all misleading. It does change CSS files, but since each of them is a Bootswatch theme, I wonder if something like theme-switcher would be clearer.

Changed to fox.jason.theme-switcher

When I tested on https://jason-fox.github.io/dita-bootstrap/, selecting different themes from the menu did not seem to change anything.

Bug fixed.

Within this PR, we should probably append a note below the themes carousel on the landing page, to point out that you can try them out live.

Note added d892459

Copy link
Owner

@infotexture infotexture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good (and works).

Tweaked the copy in the new note, merging…

@infotexture infotexture merged commit 5c093e1 into infotexture:develop Nov 30, 2023
1 check passed
@jason-fox jason-fox deleted the feature/toggler branch December 1, 2023 08:30
@infotexture infotexture added this to the 5.3.4 milestone Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants