Skip to content

Update MSRV to Rust 1.58 #1765

Closed
Closed
@romac

Description

@romac

Update to Rust release 1.58

🦀 Blog post

  • Update the version in rust-toolchain.toml.
    Run cargo clippy --all-features --all-targets --fix, review and commit the automatic fixes, and fix all reported lints. Try to resolve the root causes for the lints rather than silencing them with #[allow(...)].

Update the MSRV

Additional steps to perform in order to make the new minimal supported Rust version:

  • Update the rust-version fields in all Cargo.toml files.
    Update the msrv field in clippy.toml and fix all lints reported by cargo clippy --all-features --all-targets.
  • Update the MSRV shields in README files:
    • README.md
    • relayer-rest/README.md
  • Update the MSRV in the guide: guide/src/pre_requisites.md
    Add a .changelog entry to the breaking-changes section, announcing the new MSRV.

Activity

lightyear15

lightyear15 commented on Jan 14, 2022

@lightyear15

Uff...
it's hard to keep up with you guys...
I am spending more time updating my toolchain and IDE than actually developing code 😅

romac

romac commented on Jan 14, 2022

@romac
MemberAuthor

@lightyear15 Sorry about that! We'll delay the MSRV update a little bit more next time to give you and everybody more time to upgrade to the latest stable Rust. Thanks for bearing with us and for your contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Update MSRV to Rust 1.58 · Issue #1765 · informalsystems/hermes