Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-use ics02_client::Height in ics24_host::Path #1485

Open
5 tasks
seanchen1991 opened this issue Oct 22, 2021 · 0 comments
Open
5 tasks

Re-use ics02_client::Height in ics24_host::Path #1485

seanchen1991 opened this issue Oct 22, 2021 · 0 comments
Assignees
Labels
A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews O: code-hygiene Objective: cause to improve code hygiene

Comments

@seanchen1991
Copy link
Contributor

Crate

The ics24_host module in the ibc crate.

Summary

Replace Path::ClientConsensusState epoch and height with ics02_client::Height.

Problem Definition

Currently, Path::ClientConsensusState represents epoch and height as plain u64s. These should instead be encapsulated by a ics02_client::Height type.

Proposal

Change Path::ClientConsensusState { epoch: u64, height: u64 } -> Path::ClientConsensusState { height: Height }.

Acceptance Criteria

Change Path::ClientConsensusState { epoch: u64, height: u64 } -> Path::ClientConsensusState { height: Height }. Handle any ripple effects as appropriate.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@seanchen1991 seanchen1991 self-assigned this Oct 22, 2021
@romac romac changed the title Re-use ics02_client::Height in ics24_host::Path Re-use ics02_client::Height in ics24_host::Path Nov 12, 2021
@romac romac added A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews O: code-hygiene Objective: cause to improve code hygiene labels Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews O: code-hygiene Objective: cause to improve code hygiene
Projects
None yet
Development

No branches or pull requests

2 participants