Description
Crate
ibc-relayer
Summary of Bug
Hermes might issue a warning when a theoretically valid version (but not semantic version).
Version
v.0.6.2
Steps to Reproduce
Running Hermes on a chain that has a version such as 0.42.0-rc0
might trigger this. For example the compatibility list requires >=0.41.3 and <= 0.42.6
.
Sep 08 10:30:46.443 WARN Hermes health check failed while verifying the application compatibility for chain regen-1:http://[ip_address]:9090/; caused by: SDK module at version '0.42.0-rc0' does not meet compatibility requirements >=0.41.3, <=0.42.6 for application regen:v1.0.0-1b7c80ef102d3ae7cc40bba3ceccd97a64dadbfd Sep 08 10:30:46.443 WARN some Hermes features may not work in this mode!
Acceptance Criteria
I'm not sure if there's a easy way to check compatibility if chains don't follow a semantic versioning scheme. Since this is a warning it's not a high priority for now. Just reporting it.
For Admin Use
- Not duplicate issueAppropriate labels appliedAppropriate milestone (priority) appliedAppropriate contributors taggedContributor assigned/self-assigned
Activity
romac commentedon Sep 16, 2021
This indeed follows the semver spec: (emphasis mine)
Which means that the spec leaves the handling of pre-release version to us. If we feel that's the right to do, I guess we could match against the version without the pre-release version. What do you think @andynog @adizere?