Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor the UI in OSS #212

Closed
drdelambre opened this issue Oct 26, 2020 · 5 comments
Closed

Vendor the UI in OSS #212

drdelambre opened this issue Oct 26, 2020 · 5 comments
Labels

Comments

@drdelambre
Copy link
Contributor

We dont want OSS to have to install yarn and build the frontend to install a db. Keeping the source in two places also hurts our strategy to keep operational overhead low for OSS support: https://github.com/influxdata/idpe/issues/8963. Lets vendor the frontend assets in the OSS repo.

The workflow is basically that whenever someone pushes into a special branch (lets call it the oss branch), circle should build the frontend in OSS mode, capture the assets, and make a PR against influxdata/influxdb.

The location of the folder it dumps the assets into doesn't matter that much, as we're also going to have to update the makefiles and readmes in influxdata/influxdb to reference whatever folder you chose instead of what they currently link the --assets flag to.

And once we have compiled assets being checked into influxdb, we should remove the ui folder to ensure that influxdata/ui is the only place where we can update the source code

@danxmoran
Copy link
Contributor

Something to consider while implementing this: #334

@drdelambre drdelambre removed their assignment Nov 17, 2020
@drdelambre
Copy link
Contributor Author

yus. i think whatever comes out of this ticket will choose the timing and implementation details of that ticket, so i moved it to blocked. don't wanna be prescriptive, but migrating that page to use /health should be a fast follow to closing this one

@drdelambre
Copy link
Contributor Author

it has been requested that ui create releases, scoped to an OSS branch, and have tar'd assets be attached to the tags of those releases, so that we can keep assets outside of the repo, and instead modify the makefile to pull in and unwrap those assets.

@jzahnd
Copy link

jzahnd commented Mar 8, 2021

Lets talk with the edge team

@appletreeisyellow
Copy link
Contributor

This is done in influxdata/influxdb#21090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants