fix: mysql: type conversion follow-up #9966
Conversation
fxedel
changed the title
|
Resolves #5055 |
There was a problem hiding this comment.
Very nice update @fxedel! Only one more comment about the log-level. I think you should use acc.AddError() there to make the error visible. The only exception could be an "expected" error which occurs often in certain setups, but I think that's not the case there.
plugins/inputs/mysql/mysql.go
Outdated
|
|
||
| value, err := m.parseValueByDatabaseTypeName(colValue, col.DatabaseTypeName()) | ||
| if err != nil { | ||
| m.Log.Debugf("Error parsing %s=%q: %v", colName, string(colValue), err) |
There was a problem hiding this comment.
If this is really an error please use acc.AddError() to make those visible. In any case, I think debugging is too invisible as you can only see those when starting telegraf in debug mode. So either acc.AddError() or m.Log.Errorf() here.
plugins/inputs/mysql/mysql.go
Outdated
| m.Log.Debugf("Error parsing %s=%q: %v", key, string(val), err) | ||
| continue |
|
@srebhan Thanks for your reply. Adding errors to the accumulator to make them visible seems like a good idea. However, since Plus, I changed |
srebhan
added
the
ready for final review
(cherry picked from commit f7827a0)
Required for all PRs:
follow-up to #9403: