Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add measurements from puppet 5 #9706

Merged
merged 5 commits into from
Sep 21, 2021
Merged

feat: add measurements from puppet 5 #9706

merged 5 commits into from
Sep 21, 2021

Conversation

johnseekins
Copy link
Contributor

  • Updated associated README.md.
  • Wrote appropriate unit tests.
  • Pull request title or commits are in conventional commit format (e.g. feat: or fix:)

Puppet >= 5.x has additional measurements (largely around timing) that may be useful.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Sep 1, 2021
Copy link
Contributor

@sspaink sspaink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! This does seem more like a feature then a bugfix, I updated the title to use "feat:" instead. Feel free to correct me if I am wrong with this assumption.

@sspaink sspaink changed the title fix: add measurements from puppet 5 feat: add measurements from puppet 5 Sep 15, 2021
@sspaink sspaink added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 15, 2021
@powersj powersj merged commit 90d0878 into influxdata:master Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants