-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Extend regexp processor do allow renaming of measurements, tags and fields #9561
Conversation
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @srebhan! Someone was just asking about this functionality yesterday. The extended measurement functionality looks great and nice refactor.
Hi, I tested the assembly, it works as expected on my data (correct replacement of metric names). |
👋🏼 Friendly bump to see if it's something that can be shipped? |
…gular expressions.
949d63c
to
5738886
Compare
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
…r unused 'result_key' for metrics_rename sections.
📦 Looks like new artifacts were built from this PR. Expand this list to get them here! 🐯Artifact URLs |
@reimda can you sign-off on this PR? You had a previous discussion around naming and functionality that would be good to get your +1 on. Thanks! |
During my first review I thought there was overlap of functionality with the old settings and new ones. It makes much more sense looking at it now. Sorry to delay merging. @srebhan Was there anything else you wanted to change? |
No I'm happy with the current state when you are. :-) |
What version can we expect this to be part of? |
Hi, it is already available in the latest versions. |
resolves #5159
resolves #9506
resolves #9557
related to #6830, #6831
With this PR, the
regexp
processor is able to rename measurements, tags and fields using regular expressions. To do so, the user specifies what to rename using thekey
property. Furthermore, the user has control over the behavior in case the resulting tag or field name already exists by changing theresult_key
value betweenoverwrite
andkeep
.