feat: Openstack input plugin

[singamSrikar]

added openstack input plugin to gather metrics from openstack services

Required for all PRs:

• Updated associated README.md.
• Wrote appropriate unit tests.

resolves #243

[singamSrikar]

Hi @sjwang90 and @srebhan ,
This is the new PR for openstack input plugin.

[sjwang90]

Thanks @singamSrikar. We'll get a review on this PR.

[srebhan]

Looks good to me. Thanks @singamSrikar for the contribution. The only issue I see is the missing tests, but given the code I guess it is not easily possible to mock some stack responses, is it?

[singamSrikar]

Looks good to me. Thanks @singamSrikar for the contribution. The only issue I see is the missing tests, but given the code I guess it is not easily possible to mock some stack responses, is it?

yeah, that is right. There are few applications which can mock the Openstack APIs but that would be an additional dependency.

[srebhan]

@singamSrikar TBH I think the additional dependency is well spent. Can you please add such a test-case as it will probably trap changes in telegraf that might break this plugin and eases the live of all other devs.

[srebhan]

Oh and we do have linter warnings again... :-S

[singamSrikar]

@singamSrikar TBH I think the additional dependency is well spent. Can you please add such a test-case as it will probably trap changes in telegraf that might break this plugin and eases the live of all other devs.

I have checked the Openstack api mimic but looks like it doesn't have latest api version support, which we are using, and it requires us to run a system level service with ports enabled to mimic.

[srebhan]

Is there a docker container for this mockup? If so, we should add a test-case in non-short mode. Take a look at e.g. https://github.com/influxdata/telegraf/blob/master/plugins/inputs/sql/sql_test.go on how to do it.

[srebhan]

Please fix the linter warnings.

[singamSrikar]

Is there a docker container for this mockup? If so, we should add a test-case in non-short mode. Take a look at e.g. https://github.com/influxdata/telegraf/blob/master/plugins/inputs/sql/sql_test.go on how to do it.

I have checked but there is no mockup that would work here.

[srebhan]

Looks good to me. Unfortunately, we have to live without tests as there seems to be no mockup...

[powersj]

Thank for this! This is great.

I do want the warning about cardinality/# of tags to be more prominent in the readme. can you update that with my items and then look at my other comment about status?

Thanks!

[powersj]

Almost there :)

[telegraf-tiger]

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1% increase)

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here! 🐯

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armel.deb	armv6hl.rpm	freebsd_armv7.tar.gz
armhf.deb	i386.rpm	freebsd_i386.tar.gz
i386.deb	ppc64le.rpm	linux_amd64.tar.gz
mips.deb	s390x.rpm	linux_arm64.tar.gz
mipsel.deb	x86_64.rpm	linux_armel.tar.gz
ppc64el.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_s390x.tar.gz
		static_linux_amd64.tar.gz

[singamSrikar]

Almost there :)

Hey @powersj, I have added the changes as suggested to README doc, please take a look and let me know if any changes are required.

[srebhan]

Happy when you are... ;-)

[yankcrime]

I can't help but feel like a nod to the original author of a large part of this plugin, @spjmurray, would've been the right thing to do here - especially since he unsuccessfully attempted to shepherd the original PR for several years before eventually giving up due to lack of traction on the InfluxData side.

[srebhan]

Hey @yankcrime, I'm sorry for this lurking around so long (though I'm not with InfluxData). As you might have noticed I tried to reactivate the "old" PR, but unfortunately the original author did not react on any of my attempts. This PR was linked to the original one and I really appreciate the work @spjmurray put into this, but I have no means to reach him beside Github comments...
So sorry if this feels disrespectful, it never was meant like this!