Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive fixes - part 4 #8981

Merged
merged 3 commits into from
Mar 12, 2021
Merged

Revive fixes - part 4 #8981

merged 3 commits into from
Mar 12, 2021

Conversation

zak-pawel
Copy link
Collaborator

Revive is fast, configurable, extensible, flexible, and beautiful linter for Go. Drop-in replacement of golint.

This is part4 of fixes for problems found for following set of rules:

  • [rule.empty-lines]
    • Warns when there are heading or trailing newlines in a block -> Sometimes gofmt is not enough to enforce a common formatting of a code-base; this rule warns when there are heading or trailing newlines in code blocks..
    • This PR contains fixes for more than 400 issues found by this rule.

Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Mar 12, 2021
Copy link
Contributor

@sspaink sspaink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zero linter errors here we come.

@sspaink sspaink merged commit 38c61c0 into influxdata:master Mar 12, 2021
jblesener pushed a commit to jblesener/telegraf that referenced this pull request Apr 18, 2021
empty-lines

Co-authored-by: Pawel Zak <Pawel Zak>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants