Couchbase input plugin #866
Conversation
Make `go vet` happy.
| if err != nil { | ||
| return err | ||
| } | ||
| pool, err := client.GetPool("default") |
There was a problem hiding this comment.
make the pool name configurable?
There was a problem hiding this comment.
Here you can make the client and pool getting a "pluggable" function. That way you can write unit tests that plugin a function that returns a mocked pool.
Shouldn't be too hard to create the mocked return data because the go data structures are based off JSON, so you should be able to use json.Marshal with some sample json.
There was a problem hiding this comment.
@sparrc, default is the only possible pool name. It's a placeholder for a possible future Couchbase feature (see explanation).
|
Overall looks good, but looking through the go-couchbase code it really doesn't look very hard to mock, so I think you should write unit tests for this |
| - units: bytes | ||
| - tags: `cluster`, `hostname` | ||
|
|
||
| Measurement names: |
There was a problem hiding this comment.
these are actually "field names"
Proper terminology and case. Exmaples for tags. Example output.
|
great, thanks @ljosa!! |
Input plugin for Couchbase. There are many more metrics that could be collected, but this is enough to be useful and all I need for now. Resolves #482.