Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add metric name pass/drop filter #730

Closed
wants to merge 1 commit into from

Conversation

titilambert
Copy link
Contributor

As discuss #707, I made this PR to add metric ( measurement ) name pass/drop filter.
Specs was:

  1. Rename pass/drop to field_pass/field_drop (but keep legacy support)
  2. Add metric_pass/metric_drop for dropping by metric names
  3. Also make this consistent in output plugins. I believe output plugins currently pass/drop by metric name (I don't think we need to implement field_pass/field_drop for them yet)
  4. Keep it all glob matching for now....if we need regex we can implement as separate arg or add a prefix to indicate regex
  1. : OK
  2. : OK
  3. : I'm not sure to understand :/
  4. : OK

@sparrc if you re OK with the implementation, I will add some tests.

@sparrc
Copy link
Contributor

sparrc commented Feb 20, 2016

yes, thanks @titilambert, as to (3) I don't think there is anything to do so don't worry about that.

You'll also need to change the documentation to match these new names.

@titilambert
Copy link
Contributor Author

@sparrc tests and doc added !

@sparrc sparrc closed this in 5aef725 Feb 22, 2016
@titilambert titilambert deleted the metric_filter branch March 7, 2016 19:59
geodimm pushed a commit to miketonks/telegraf that referenced this pull request Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants