fix(config): allow remote config with no auth #6469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding an `Authorization: Token <token>` header causes 404 errors with GitHub when using the raw content URI. This fix only adds the header when the token is available, allowing for public configs to be loaded correctly.
danielnelson
pushed a commit
that referenced
this pull request
Sep 30, 2019
(cherry picked from commit 367dee7)
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
(cherry picked from commit 367dee7)
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an
Authorization: Token <token>header causes 404 errors with GitHub when using the raw content URI.This fix only adds the header when the token is available, allowing for public configs to be loaded correctly.
Required for all PRs:
You can test this with:
telegraf --config https://raw.githubusercontent.com/influxdata/telegraf/master/etc/telegraf.confTo see the HTTP behaviour without Telegraf:
Returns 404:
curl -X GET -H "Authorization: Token ABC" -H "Accept: application/toml" -I https://raw.githubusercontent.com/influxdata/telegraf/master/etc/telegraf.confReturns 200
curl -X GET -H "Accept: application/toml" -I https://raw.githubusercontent.com/influxdata/telegraf/master/etc/telegraf.conf