Use sarama built in support for consumer groups #6172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glinton
approved these changes
Jul 26, 2019
| log.Printf("I! WARNING: Kafka consumer invalid offset '%s', using 'oldest'", | ||
| k.Offset) | ||
| config.Consumer.Offsets.Initial = sarama.OffsetOldest | ||
| return fmt.Errorf("invalid offset %q", k.Offset) |
There was a problem hiding this comment.
Is this something that will need to be documented upfront, as previously bad values would be set to a default?
There was a problem hiding this comment.
I think this change is okay, we always warned and the value was never valid.
danielnelson
force-pushed
the
sarama-consumer-groups
branch
3 times, most recently
from
4a2d3c6
to
a215be7
Compare
danielnelson
force-pushed
the
sarama-consumer-groups
branch
from
2b68c8a
to
15b999f
Compare
danielnelson
commented
Jul 30, 2019
| VERSION := $(shell git describe --exact-match --tags 2>nil) | ||
| HOME := $(HOMEPATH) | ||
| CGO_ENABLED ?= 0 | ||
| export CGO_ENABLED |
There was a problem hiding this comment.
Switched over to disabling CGO in Windows unless explicitly enabled. Not entirely sure this is a good idea but I'm trying to avoid the confusion of suddenly needing gcc to build.
3 tasks
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use sarama built in support for consumer groups instead of the, now deprecated, sarama-cluster library. Hoping this will help with #6136
Required for all PRs: