-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redis input: fix percentage value parsing #6163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before:
After:
Example values queries thru the Prometheus output interface. |
melor
force-pushed
the
aiven_redis_perc_19
branch
from
July 24, 2019 10:06
db4c6e1
to
10c4556
Compare
GeorgeMac
reviewed
Jul 24, 2019
Cheers for the contribution @melor ! Would you mind adding a case to the tests to validate this? |
Percentage values would get interpreted incorrectly as tags because they did not pass the int/float conversion.
melor
force-pushed
the
aiven_redis_perc_19
branch
from
July 24, 2019 11:03
10c4556
to
1322892
Compare
Related: #5036 |
GeorgeMac
approved these changes
Jul 24, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Percentage values would get interpreted incorrectly as tags because they
did not pass the int/float conversion.
Required for all PRs: