Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on system binary from ping input plugin #6050

Merged
merged 17 commits into from
Jul 11, 2019
Merged

Remove dependency on system binary from ping input plugin #6050

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ad024c6
WIP: add native ping
AlirieGray Apr 29, 2019
2d173e2
Attempt to record accurate ping time
glinton May 6, 2019
f097abb
Conditionally use system ping
glinton May 7, 2019
f2ec8e4
WIP
glinton May 13, 2019
14e7794
Update go-ping
glinton Jun 12, 2019
f319653
Enforce timeout
glinton Jun 12, 2019
ace14ac
Merge branch 'master' into feat/native-ping-new
glinton Jun 26, 2019
0272ec1
Use updated library interface
glinton Jun 26, 2019
42198df
Update dependency
glinton Jun 27, 2019
2317bbb
Update method logic and add test
glinton Jun 27, 2019
b734cab
fmt
glinton Jun 27, 2019
6563913
Update readme
glinton Jul 2, 2019
701c744
Merge branch 'master' into feat/native-ping-new
glinton Jul 2, 2019
05b0e4a
Fix typos in readme
glinton Jul 2, 2019
4a1dddf
Address feedback
glinton Jul 3, 2019
ecdf5f2
Set ttl only on supported platforms
glinton Jul 3, 2019
a5808b4
fmt tests
glinton Jul 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fmt tests
  • Loading branch information
@glinton
glinton committed Jul 3, 2019
commit a5808b45d17bafcf03459493f96e911cacc94fa2
16 changes: 8 additions & 8 deletions plugins/inputs/ping/ping_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,10 @@ func TestPingGather(t *testing.T) {
acc.GatherError(p.Gather)
tags := map[string]string{"url": "localhost"}
fields := map[string]interface{}{
"packets_transmitted": 5,
"packets_received": 5,
"percent_packet_loss": 0.0,
"ttl": 63,
"packets_transmitted": 5,
"packets_received": 5,
"percent_packet_loss": 0.0,
"ttl": 63,
"minimum_response_ms": 35.225,
"average_response_ms": 43.628,
"maximum_response_ms": 51.806,
Expand Down Expand Up @@ -229,10 +229,10 @@ func TestLossyPingGather(t *testing.T) {
acc.GatherError(p.Gather)
tags := map[string]string{"url": "www.google.com"}
fields := map[string]interface{}{
"packets_transmitted": 5,
"packets_received": 3,
"percent_packet_loss": 40.0,
"ttl": 63,
"packets_transmitted": 5,
"packets_received": 3,
"percent_packet_loss": 40.0,
"ttl": 63,
"minimum_response_ms": 35.225,
"average_response_ms": 44.033,
"maximum_response_ms": 51.806,
Expand Down