-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for gzip compression to amqp input and output #5830
Conversation
We should add in the compression message property so we know in RMQ if it is compressed. This should be set based on if compression is enabled or not. Content encoding, e.g. "gzip". Used by applications, not core RabbitMQ Content type, e.g. "application/json". Used by applications, not core RabbitMQ |
Also tested with and without gzip compression Without compression the size on disk was over 4gb. With compression turned on it was 7kB. I would consider that a success @danielnelson It might be worth testing to see what the additional overhead against Telegraf is for enabling compression but I think it is worth it |
I added the Content-Encoding property, but held off on the Content-Type. I think we should first make this part of the serializer interface separately so that we can pick the right value in a nice way. Another idea that this brings up is doing automatic decoding on the consumer side based on the property, I think it could be nice but I'll have to leave that for later. |
closes #3557
Required for all PRs: