Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlserver: fix type overflow in perf counter query #5261

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

schwartzmx
Copy link
Contributor

  • when using the money type, large values can cause arithmetic overflow
    exceptions
  • use decimal(19,4) in favor of money
  • fixes '[inputs.sqlserver]: Error in plugin: mssql: Arithmetic overflow
    error converting expression to data type money.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

- when using the money type,  large values can cause arithmetic overflow
  exceptions
- use decimal(19,4) in favor of money
- fixes '[inputs.sqlserver]: Error in plugin: mssql: Arithmetic overflow
  error converting expression to data type money.
@danielnelson danielnelson added this to the 1.9.3 milestone Jan 8, 2019
@danielnelson danielnelson added the fix pr to fix corresponding bug label Jan 8, 2019
@danielnelson danielnelson merged commit 1c3acaf into influxdata:master Jan 8, 2019
danielnelson pushed a commit that referenced this pull request Jan 8, 2019
@schwartzmx schwartzmx deleted the sqlserver-overflow branch January 9, 2019 03:46
trevorwhitney pushed a commit to trevorwhitney/telegraf that referenced this pull request Feb 14, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants