Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5132 & 5067 #5135

Merged
merged 13 commits into from
Dec 13, 2018
Merged

Issue 5132 & 5067 #5135

merged 13 commits into from
Dec 13, 2018

Conversation

m82labs
Copy link
Contributor

@m82labs m82labs commented Dec 11, 2018

This PR will fix issues 5132 and 5067:

  • Removed the storage calculation for SQL Server instances that are NOT Azure Managed Instances, this reduces the time it takes to get this data on an instance with a lot of databases and/or database files
  • Added the SQL Server version back to the server properties query

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Gopkg.lock Outdated
@@ -143,7 +143,7 @@

[[projects]]
branch = "master"
digest = "1:0828d8c0f95689f832cf348fe23827feb7640cd698d612ef59e2f9d041f54c68"
digest = "1:5a5f28fcfe3a74247733a31ceaac0e53bfc2723e43c596b2e3f110eda9378575"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this file? I'm not sure why it changed, but you should be able to run dep ensure and have it remain unchanged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this now. Not sure what happened there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielnelson I ran dep ensure and the digest remained the same. Not sure if I can just edit the file by hand or what.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I fixed it, I just grabbed the copy from master.

@danielnelson danielnelson added this to the 1.9.2 milestone Dec 11, 2018
@danielnelson danielnelson added performance problems with decreased performance or enhancements that improve performance fix pr to fix corresponding bug area/sqlserver labels Dec 11, 2018
@danielnelson danielnelson merged commit 503f3ce into influxdata:master Dec 13, 2018
danielnelson pushed a commit that referenced this pull request Dec 13, 2018
…rver version (#5135)

- Removed the storage calculation for SQL Server instances that are NOT Azure
  Managed Instances, this reduces the time it takes to get this data on an
  instance with a lot of databases and/or database files.
- Added the SQL Server version back to the server properties query.
trevorwhitney pushed a commit to trevorwhitney/telegraf that referenced this pull request Feb 14, 2019
…rver version (influxdata#5135)

- Removed the storage calculation for SQL Server instances that are NOT Azure
  Managed Instances, this reduces the time it takes to get this data on an
  instance with a lot of databases and/or database files.
- Added the SQL Server version back to the server properties query.
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
…rver version (influxdata#5135)

- Removed the storage calculation for SQL Server instances that are NOT Azure
  Managed Instances, this reduces the time it takes to get this data on an
  instance with a lot of databases and/or database files.
- Added the SQL Server version back to the server properties query.
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
…rver version (influxdata#5135)

- Removed the storage calculation for SQL Server instances that are NOT Azure
  Managed Instances, this reduces the time it takes to get this data on an
  instance with a lot of databases and/or database files.
- Added the SQL Server version back to the server properties query.
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
…rver version (influxdata#5135)

- Removed the storage calculation for SQL Server instances that are NOT Azure
  Managed Instances, this reduces the time it takes to get this data on an
  instance with a lot of databases and/or database files.
- Added the SQL Server version back to the server properties query.
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
…rver version (influxdata#5135)

- Removed the storage calculation for SQL Server instances that are NOT Azure
  Managed Instances, this reduces the time it takes to get this data on an
  instance with a lot of databases and/or database files.
- Added the SQL Server version back to the server properties query.
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
…rver version (influxdata#5135)

- Removed the storage calculation for SQL Server instances that are NOT Azure
  Managed Instances, this reduces the time it takes to get this data on an
  instance with a lot of databases and/or database files.
- Added the SQL Server version back to the server properties query.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sqlserver fix pr to fix corresponding bug performance problems with decreased performance or enhancements that improve performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants