Adding Kafka Origin Topic tag. #5038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glinton
suggested changes
Nov 27, 2018
| @@ -256,7 +262,11 @@ func (k *Kafka) onMessage(acc telegraf.TrackingAccumulator, msg *sarama.Consumer | |||
| if err != nil { | |||
| return err | |||
| } | |||
|
|
|||
| if k.AddTopicTag { | |||
There was a problem hiding this comment.
It would probably be better to just check if the TopicTagName is not empty and set it if so in order to prevent issues adding a blank tag.
There was a problem hiding this comment.
Along these lines, let's just have a single option that controls the topic tag. If it is empty, the default, don't add the tag:
## If set, add the topic with the given tagkey to all metrics.
## ex: topic_tag = "topic"
# topic_tag = ""
There was a problem hiding this comment.
Thanks for the quick feedback, I've updated as requested; this way is a lot clearer and straight forward.
glinton
added
feat
The Kafka consumer input plugin has already the ability to read from multiple topics, however it does not retain the topic which the data was read from. That data is very useful to introduce some smart routing down the line. The change adds the topic as a tag. The tag name is configurable. Added some basic tests, and tested on multiple kafka clusters.
glinton
approved these changes
Nov 28, 2018
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kafka consumer input plugin has already the ability to
read from multiple topics, however it does not retain the
topic which the data was read from. That data is very useful
to introduce some smart routing down the line.
The change adds the topic as a tag. The tag name is configurable.
Added some basic tests, and tested on multiple kafka clusters.
Required for all PRs: