Remove outputs blocking inputs when output is slow #4938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glinton
approved these changes
Oct 31, 2018
| Write(metrics []Metric) error | ||
|
|
||
| // Start the "service" that will provide an Output | ||
| Start() error |
There was a problem hiding this comment.
Do service plugins replace Start and Stop implementations with Connect and Close?
There was a problem hiding this comment.
Yes, I'm not sure what the point of this extra interface was, only the prometheus output was a ServiceOutput.
danielnelson
force-pushed
the
flush-no-block
branch
2 times, most recently
from
0d8c445
to
b44090b
Compare
danielnelson
force-pushed
the
flush-no-block
branch
from
b44090b
to
0c0b5bd
Compare
danielnelson
force-pushed
the
flush-no-block
branch
from
0c0b5bd
to
b545796
Compare
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request remove blocking during flushes and writes immediately to the metric buffer. This should improve throughput especially when outputs are slow, and degrade better when overloaded.
closes #2919
To avoid over consumption in queue consumers it introduces a way to track metrics and be notified when they are delivered, allowing for durable handling in the consumer inputs. This is done by reference counting the metrics as they move through Telegraf which does add some additional implementation requirements to processors and consumer inputs.
closes #3984
The agent was refactored to fix issues restarting and shutting down when under load:
closes #4283
closes #4457
closes #4610
As part of the agent refactor, the timing alignment is fixed:
closes #3968
Add per output
flush_interval,metric_buffer_limitandmetric_batch_size.closes #4717
What still needs done:
Required for all PRs: