Improve AWS Kinesis IAM Security #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the plugin's stream discovery to use DescribeStreamSummary[1] in favor of ListStreams[2]. The API switch has the following benefits. * Faster Startup - Previously, the configured stream had to be compared against all available streams (possibly paginating the results) to check its existence. Now it just calls a single API. * Improved Security - Previously, the AWS IAM credentials had to have read access to list all available streams. Now the AWS IAM credentials can restrict operations to a specific Kinesis stream ARN. * Improve API Limits - Per the AWS documentation, DescribeStreamSummary[1] has a limit of 20 transactions per second while ListStreams[2] has a limit of 5 transaction per second. [1] https://docs.aws.amazon.com/kinesis/latest/APIReference/API_DescribeStreamSummary.html [2] https://docs.aws.amazon.com/kinesis/latest/APIReference/API_ListStreams.html
danielnelson
added
the
feat
danielnelson
approved these changes
Oct 15, 2018
glinton
approved these changes
Oct 17, 2018
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the plugin's stream discovery to use DescribeStreamSummary[1]
in favor of ListStreams[2]. The API switch has the following benefits.
Faster Startup - Previously, the configured stream had to be compared
against all available streams (possibly paginating the results) to check
its existence. Now it just calls a single API.
Improved Security - Previously, the AWS IAM credentials had to have
read access to list all available streams. Now the AWS IAM credentials
can restrict operations to a specific Kinesis stream ARN.
Improve API Limits - Per the AWS documentation, DescribeStreamSummary[1]
has a limit of 20 transactions per second while ListStreams[2] has a limit
of 5 transaction per second.
[1] https://docs.aws.amazon.com/kinesis/latest/APIReference/API_DescribeStreamSummary.html
[2] https://docs.aws.amazon.com/kinesis/latest/APIReference/API_ListStreams.html
Required for all PRs: