Issue #3911 Add telegraf version to User-Agent header for http requests #4838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glinton
approved these changes
Oct 10, 2018
plugins/outputs/http/http_test.go
Outdated
| @@ -10,6 +10,8 @@ import ( | |||
| "testing" | |||
| "time" | |||
|
|
|||
| "github.com/influxdata/telegraf/internal" | |||
|
|
|||
There was a problem hiding this comment.
This import can be grouped with the other influxdata/telegraf ones
glinton
added
the
feat
danielnelson
approved these changes
Oct 10, 2018
danielnelson
suggested changes
Oct 10, 2018
There was a problem hiding this comment.
I just noticed in the issue that I suggested using a slash instead of a space Telegraf/1.8.2, I think we should use the slash to be more compliant with https://tools.ietf.org/html/rfc2616#section-14.43 by using a product token
kevinconaway
force-pushed
the
issue-3911-add-version
branch
from
707d63d
to
5d05046
Compare
|
@danielnelson Thanks, I learned something new today re: product tokens. I've incorporated that feedback as well as fixed the ungrouped import per @glinton's feedback |
danielnelson
approved these changes
Oct 11, 2018
rgitzel
pushed a commit
to rgitzel/telegraf
that referenced
this pull request
Oct 17, 2018
Header is added in influxdb, influxdb_v2, and http outputs.
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
Header is added in influxdb, influxdb_v2, and http outputs.
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
Header is added in influxdb, influxdb_v2, and http outputs.
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
Header is added in influxdb, influxdb_v2, and http outputs.
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Header is added in influxdb, influxdb_v2, and http outputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
@danielnelson This PR adds a
User-Agent: Telegraf X.Y.Zversion to outbound http requests for the following output plugins: