-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support IPv6 in the ping plugin #4703
Conversation
The way we've been planning to implement this is with a new option to override the ping command used as well as a way to set arguments directly. If you needed to do some ipv4 and some ipv6 urls then you would define the plugin twice.
Do you think you could change around the options like this? |
@danielnelson so the existing options for ping input (ex. ping_interval, timeout, deadline) will be replaced by "arguments"? |
Yes, I think what would be best is if when |
@danielnelson can you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a quick glance. @glinton Can you do a more indepth review?
Required for all PRs:
close #2159
by using
arguments
options, use can determine packet size himself. so it can close #2830