-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oauth2 support in HTTP output plugin #4536
Conversation
Support for OAuth2 Authentication in http output plugin. The golang client credentials librarty supports token reuse untill its expiry.
fmt check done |
dep ensure -vendor-only fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed test errors
test |
@vikrant6 Thanks for the PR. I'll try to take a look soon, ping me when you have the tests passing on circleci or if you need help. |
@danielnelson I very new to go and might be missing something basic here. Need your help go vet $(go list ./... | grep -v ./plugins/parsers/influx) |
This error is due to the new dependency not being added to the lock file. You don't want to edit it by hand though, undo your changes to Gopkg.toml and run:
Then make sure there are no errors when you run:
|
@danielnelson Thanks. vet is failing for some packages (existing) Any idea how to proceed? |
@danielnelson - Any pointer on how to proceed from here? |
@vikrant6 Is it alright if I fix it up and push to your fork? |
@danielnelson - Please go ahead. Thanks. |
I fixed up the dep issue, cleaned up some whitespace changes, and switch the client over to using the oauth2.Client and added some tests. I made some minor tweaks to the config file variable names as well. Here is the rpm from CircleCI telegraf-1.8.0~f6efa1a9-0.x86_64.rpm |
@danielnelson Thank you ! |
@danielnelson What's next for this to merge ? Is there a milestone identified? |
We should be able to add this to 1.8. Since I don't have a real system to do a final testing, can you let me know if everything is working? |
@danielnelson Found that it no longer honors the configuration "insecure_skip_verify=true" |
I think this will fix it: c1dc2d0 Updated package: telegraf-1.8.0~c1dc2d06-0.x86_64.rpm |
Support for OAuth2 Authentication in http output plugin.
The golang client credentials librarty supports token reuse untill its expiry.
Required for all PRs: