Update vendoring to dep from gdm #4314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because dep and hashicorp/consul.
|
closes #3100 |
.circleci/config.yml
Outdated
| - run: 'make deps' | ||
| - save_cache: |
There was a problem hiding this comment.
It looks like this doesn't cache the new data because the cache is immutable:
Skipping cache generation, cache already exists for key: vendor
Found one created at 2018-06-18 20:19:31 +0000 UTC
There was a problem hiding this comment.
I'd imagine its because nothing changed, but i'll make sure there isn't some update_cache type entry.
.gitignore
Outdated
| @@ -2,3 +2,4 @@ | |||
| /telegraf | |||
| /telegraf.exe | |||
| /telegraf.gz | |||
| vendor/ | |||
There was a problem hiding this comment.
Nitpick: /vendor because what if I want to make internal/vendor/stupid_example.go?
| @@ -42,7 +42,7 @@ Ansible role: https://github.com/rossmcdonald/telegraf | |||
|
|
|||
| Telegraf requires golang version 1.9 or newer, the Makefile requires GNU make. | |||
|
|
|||
| Dependencies are managed with [gdm](https://github.com/sparrc/gdm), | |||
| Dependencies are managed with [dep](https://github.com/golang/dep), | |||
There was a problem hiding this comment.
Also take a look through CONTRIBUTING.md for more gdm references.
mkboudreau
added a commit
to mkboudreau/telegraf
that referenced
this pull request
Jun 22, 2018
* origin: (39 commits) Document path tag in tail input Update changelog Added path tag to tail input plugin (influxdata#4292) Run windows tests with -short Fix postfix input handling of multi-level queues (influxdata#4333) Update changelog Add support for comma in logparser timestamp format (influxdata#4311) Update vendoring to dep from gdm (influxdata#4314) Update changelog Add new measurement with results of pgrep lookup to procstat input (influxdata#4307) Update changelog Add valuecounter aggregator plugin (influxdata#3523) Update changelog Update docker input documentation for container status Add container status tag to docker input (influxdata#4259) Drop CI support for Go 1.8 (influxdata#4309) Update changelog Fix selection of tags under nested objects in the JSON parser (influxdata#4284) Update changelog Add owner tag on partitions in burrow input (influxdata#4281) ...
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
glinton
added a commit
that referenced
this pull request
Jun 26, 2018
rgitzel
pushed a commit
to rgitzel/telegraf
that referenced
this pull request
Oct 17, 2018
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
depas telegraf's dependency manager.Resolves #3394
Closes #3564
Required for all PRs: