Add repl_oplog_window_s metric to mongodb input #3964
Conversation
subuk
force-pushed
the
master
branch
2 times, most recently
from
64913c1 to
dfb269c
Compare
danielnelson
added
feat
There was a problem hiding this comment.
Thanks @subuk, this is a great addition, I do have a couple suggestions:
plugins/inputs/mongodb/README.md
Outdated
| @@ -57,6 +57,7 @@ and create a single measurement containing values e.g. | |||
| * ttl_passes_per_sec | |||
| * repl_lag | |||
| * jumbo_chunks (only if mongos or mongo config) | |||
| * oplog_timediff | |||
There was a problem hiding this comment.
I think we should call the field repl_oplog_window_s. This more closely matches the linked documentation from mongodb, while still using the same repl prefix as the other replication metrics and also includes the units. I sort of dislike _s because its not immediately clear what it means, but it matches more in style with existing _ns readings.
There was a problem hiding this comment.
Okay, I will rename oplog_timediff to repl_oplog_window_s and move it closer to other repl_* metrics in code.
| localdb := s.Session.DB("local") | ||
| oplog_collection_name := "" | ||
|
|
||
| collection_names, err := localdb.CollectionNames() |
There was a problem hiding this comment.
It seems like instead of checking for the existence of this items we should just try to get the data and if it's not there then we don't report anything. This will result in less network calls and checking doesn't guarantee the data will be there later anyway due to possible changes.
How about we just try to get the entries for oplog.rs and if that fails we can try oplog.$main?
There was a problem hiding this comment.
Yeah, it makes sense, will be fixed.
subuk
changed the title
|
Fixed. Metric renamed to repl_oplog_window_s, collection list query removed. |
|
Thank you, this will be in version 1.7.0 |
Hello!
Here is new metric named oplog_timediff.
References:
https://www.mongodb.com/blog/post/replica-set-health-is-more-than-just-replication
https://github.com/DataDog/integrations-core/blob/master/mongo/datadog_checks/mongo/mongo.py#L972
Required for all PRs: